If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Get rid of unused nsFormControlFrame methods

RESOLVED FIXED

Status

()

Core
Layout: Form Controls
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Eli Friedman, Assigned: Eli Friedman)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
GetDesiredSize, GetWidgetSize, mWidgetSize, GetWidgetInitData, SetClickPoint, mLastClickPoint, GetScrollbarWidth, ControlChanged, and EnterPressed are unused; and probably HandleEvent is unneeded.

Also, the class declarations can go, and NS_FORMSIZE_NOTSET, and the includes for nsFormControlHelper.h, nsPresContext.h, nsIWidget.h, nsCOMPtr.h.

It seems like this stuff just collects.
(Assignee)

Comment 1

12 years ago
The three-argument form of GetDesiredSize is used.
(Assignee)

Comment 2

12 years ago
Created attachment 211939 [details] [diff] [review]
Patch
Attachment #211939 - Flags: review?(roc)
Comment on attachment 211939 [details] [diff] [review]
Patch

yes, yes it does
Attachment #211939 - Flags: superreview+
Attachment #211939 - Flags: review?(roc)
Attachment #211939 - Flags: review+
(Assignee)

Comment 4

12 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 5

12 years ago
Oh, a dream comes true, removing the debug stuff from form controls will probably shrink the files by 1/3.

http://lxr.mozilla.org/seamonkey/search?string=REFLOW_DEBUG_MSG most of the reflow messages are anyway covered by the frame reflow debug mechanism (http://www.mozilla.org/newlayout/doc/frame_reflow_debug.html)
You need to log in before you can comment on or make changes to this bug.