326912 - Warnings about deprecation (C4996) when compiling firefox with VC8 express

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Régis Caspar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060211 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060211 Firefox/1.6a1

cl.exe issues lots of useless warnings that can be avoided by defining _CRT_SECURE_NO_DEPRECATE and _CRT_NONSTDC_NO_DEPRECATE


Reproducible: Always

Steps to Reproduce:
1. compile firefox with msvc 8 express edition

Actual Results:  
lots of warnings like
"warning C4996: 'strcpy' was declared deprecated
   Message: 'This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_DEPRECATE. See online help for details.'"

Expected Results:  
No warning

Note: when using 
CFLAGS="-D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE"
CXXFLAGS="-D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE"
CPPFLAGS="-D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE"
environement variables warning are issued only when building nss

Comment 1

[Régis Caspar]

more descriptive summary

Comment 2

[Benjamin Smedberg]

Attachment: Supress stupid warnings, rev. 1

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 211768 [details] [diff] [review]
Supress stupid warnings, rev. 1

r=vladimir conditional on review of bug 326849 ;)

Comment 4

[Benjamin Smedberg]

Fixed on trunk.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #2)
> Supress stupid warnings, rev. 1

Why is a warning that you shouldn't use strcpy stupid?