327039 - Macro names are not expanded causing Windows Add/Remove programs to fail.

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Bob Clary [:bc] (inactive)]

Install today's thunderbird 1.5/winxp using the installer.

While running, attempt to remove thunderbird.
$ProductNameInternal$ is ... . Please quit $ProductNameInternal$...

0: Uninstall log folder not found:

HKEY_LOCAL_MACHINE\Software\@BRAND_COMPANY_NAME@\@BRAND_PRODUCT_NAME@\1.5(en-US)\Uninstall\Uninstall Log Folder

I think this occured on the 1.5 2006-02-11 build as well.

I haven't checked trunk.

Comment 1

[Scott MacGregor]

possibly related to the uninstaller changes we took on the branch for 320504 or 307296? 

Comment 2

[Darin Fisher]

Yes, very likely.  I must have screwed up the patch for Thunderbird.  This problem is not happening for Firefox on the 1.8 branch, right?

Comment 3

[Bob Clary [:bc] (inactive)]

(In reply to comment #2)
> Yes, very likely.  I must have screwed up the patch for Thunderbird.  This
> problem is not happening for Firefox on the 1.8 branch, right?
> 

Right. I get the dialog and IE opens <https://survey.mozilla.com/1/Mozilla%20Firefox/1.5%20(en-US)/exit.html> in today's 1.8 firefox build (which is 404 by the way).

Comment 4

[Darin Fisher]

Yup, the site is not live yet.

Comment 5

[Darin Fisher]

A quick glance at the files on the 1.8 branch (w/ a fresh CVS pull) indicates that everything should be okay.  So, I'm doing a fresh build now to figure this out.

Comment 6

[Darin Fisher]

Attachment: simple fix

I mistakenly left this critical preprocessor directive out of the thunderbird version of uninstall.it :-(

I've gone ahead and landed this patch on the trunk and 1.8 branch.

Comment 7

[Darin Fisher]

fixed-on-trunk, fixed1.8.1

Comment 8

[Bob Clary [:bc] (inactive)]

I haven't checked on trunk, but the 1.5.x install still has an issue. 

Steps to reproduce.

1. Install today's tbird.
2. Start tbird.
3. Uninstall tbird while it is running.

You will see references to $productname$ etc in the windows telling you that there is an instance of tbird running...

Comment 9

[Bob Clary [:bc] (inactive)]

Still seeing the $ macro names when uninstalling when tbird is running. -> REOPEN.

Comment 10

[Darin Fisher]

OK, the $ macro names must be another issue.  Those don't prevent the uninstall from working properly, right?

Comment 11

[Bob Clary [:bc] (inactive)]

(In reply to comment #10)

Right. The $ names appear asking if you want to kill the existing running instance, then proceed to perform the uninstall properly.

Comment 12

[Darin Fisher]

Attachment: fix $ problem

Comment 13

[Darin Fisher]

fixed-on-trunk ("fix $ problem" patch)

Comment 14

[Benjamin Smedberg]

Comment on attachment 212633 [details] [diff] [review]
fix $ problem

I'll dare to approve this.

Comment 15

[Darin Fisher]

fixed1.8.1 ("fix $ problem" patch)