Status

()

Core
Networking
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

I have some patches in my tree that fix some minor things in necko... I'll use this bug for all of them, they're not worth filing one bug for each.
Created attachment 211777 [details] [diff] [review]
use the #define for the stringbundle URL
Attachment #211777 - Flags: superreview?(darin)
Attachment #211777 - Flags: review?(darin)
Created attachment 211778 [details] [diff] [review]
actually init xpcom
Attachment #211778 - Flags: review?(darin)
Created attachment 211780 [details] [diff] [review]
don't test isSuccessCode where it will always be a failure

(it's a failure because onStartRequest always throws here)
Attachment #211780 - Flags: review?(darin)
Created attachment 211781 [details] [diff] [review]
add a -pac argument to TestProtocols
Attachment #211781 - Flags: review?(darin)
Created attachment 211784 [details] [diff] [review]
misc cleanup

make stuff static, remove unused code, PRBool->PRPackedBool
Attachment #211784 - Flags: superreview?(darin)
Attachment #211784 - Flags: review?(darin)

Updated

13 years ago
Attachment #211777 - Flags: superreview?(darin)
Attachment #211777 - Flags: superreview+
Attachment #211777 - Flags: review?(darin)
Attachment #211777 - Flags: review+

Updated

13 years ago
Attachment #211778 - Flags: review?(darin) → review+

Updated

13 years ago
Attachment #211780 - Flags: review?(darin) → review+

Updated

13 years ago
Attachment #211781 - Flags: review?(darin) → review+

Comment 6

13 years ago
Comment on attachment 211784 [details] [diff] [review]
misc cleanup

hmm... I'm not so sure it makes sense to prefer PRPackedBool over PRBool when there is only one PRBool.  all your doing is forcing the CPU to read/write a byte instead of a word, and it anyways fetches a word, so there isn't much benefit to this.
Attachment #211784 - Flags: superreview?(darin)
Attachment #211784 - Flags: superreview+
Attachment #211784 - Flags: review?(darin)
Attachment #211784 - Flags: review+
checked in, except that PRPackedBool change

Checking in netwerk/base/src/nsAsyncStreamListener.cpp;
/cvsroot/mozilla/netwerk/base/src/nsAsyncStreamListener.cpp,v  <--  nsAsyncStreamListener.cpp
new revision: 1.49; previous revision: 1.48
done
Checking in netwerk/base/src/nsFileStreams.cpp;
/cvsroot/mozilla/netwerk/base/src/nsFileStreams.cpp,v  <--  nsFileStreams.cpp
new revision: 1.74; previous revision: 1.73
done
Checking in netwerk/base/src/nsLoadGroup.cpp;
/cvsroot/mozilla/netwerk/base/src/nsLoadGroup.cpp,v  <--  nsLoadGroup.cpp
new revision: 1.69; previous revision: 1.68
done
Checking in netwerk/streamconv/converters/nsIndexedToHTML.cpp;
/cvsroot/mozilla/netwerk/streamconv/converters/nsIndexedToHTML.cpp,v  <--  nsIndexedToHTML.cpp
new revision: 1.72; previous revision: 1.71
done
Checking in netwerk/test/TestOpen.cpp;
/cvsroot/mozilla/netwerk/test/TestOpen.cpp,v  <--  TestOpen.cpp
new revision: 1.8; previous revision: 1.7
done
Checking in netwerk/test/TestProtocols.cpp;
/cvsroot/mozilla/netwerk/test/TestProtocols.cpp,v  <--  TestProtocols.cpp
new revision: 1.113; previous revision: 1.112
done
Checking in netwerk/test/unit/test_cookie_header.js;
/cvsroot/mozilla/netwerk/test/unit/test_cookie_header.js,v  <--  test_cookie_header.js
new revision: 1.4; previous revision: 1.3
done
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.