mozilla/tools/update-packaging/unwrap_full_update.sh ignores paths with spaces in them

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
12 years ago
4 years ago

People

(Reporter: preed, Assigned: coop)

Tracking

Firefox Tracking Flags

(status1.9.2 .13-fixed, status1.9.1 .16-fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

12 years ago
unwrap_full_update.sh has indigestion with file paths with spaces in them (Mac OS X files).

In unwrap_full_update.sh's case, you get (with some logging added):
  decompressing Firefox.app/Contents/MacOS/plugins/Default
mv: cannot stat `Firefox.app/Contents/MacOS/plugins/Default': No such file or di
rectory
bzip2: Can't open input file Firefox.app/Contents/MacOS/plugins/Default.bz2: No 
such file or directory.
  decompressing Plugin.plugin/Contents/Resources/Default
mv: cannot stat `Plugin.plugin/Contents/Resources/Default': No such file or dire
ctory
bzip2: Can't open input file Plugin.plugin/Contents/Resources/Default.bz2: No su
ch file or directory.
  decompressing Plugin.rsrc
mv: cannot stat `Plugin.rsrc': No such file or directory
bzip2: Can't open input file Plugin.rsrc.bz2: No such file or directory.

(the full path is actually: "Firefox.app/Contents/MacOS/plugins/Default Plugin.plugin/Contents/Resources/Default")
Fixed by unwrap_full_update.pl

Checkin details:

revision 1.1
date: 2006/02/13 20:44:38;  author: benjamin%smedbergs.us;  state: Exp;
From bug 326465 - make unwrap_full_update space-aware (rewrite in perl for ease of coding and maintenance)

Perhaps CVS removal of unwrap_full_update.sh would be a good idea ? Or some documentation in the shell script indicating limitations at least.
Product: Firefox → Toolkit
Component: Application Update → Release Engineering
Product: Toolkit → mozilla.org
QA Contact: application.update → release
Version: 1.8.0 Branch → other
As per comment 1, it looks like this bug is fixed.  Please reopen if this is not the case.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
I don't see any checkins (CVS trunk or m-c) that indicate unwrap_full_update.sh has been fixed or removed. And in fact we are using it for our partial generation in nightlies builds, and are saved by plugins/Default Plugins getting deprecated. Really we should switch to unwrap_full_update.pl and remove the shell script. Got time for that coop ?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

7 years ago
(In reply to comment #3)
> Got time for that coop ?

Yeah, I'll try to get to it later in the week.
Assignee: nobody → ccooper
Severity: critical → normal
Status: REOPENED → NEW
Priority: -- → P3
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
Priority: P3 → P2
(Assignee)

Comment 5

7 years ago
Created attachment 473582 [details] [diff] [review]
Use perl script to unwrap mars for nightlies
Attachment #473582 - Flags: review?
(Assignee)

Comment 6

7 years ago
Created attachment 473585 [details] [diff] [review]
Remove the unwrap shell script [mozilla-central]
Attachment #473585 - Flags: review?
(Assignee)

Comment 7

7 years ago
Created attachment 473586 [details] [diff] [review]
Remove the unwrap shell script [mozilla-1.9.2]
Attachment #473586 - Flags: review?
(Assignee)

Comment 8

7 years ago
Created attachment 473587 [details] [diff] [review]
Remove the unwrap shell script [mozilla-1.9.1]
Attachment #473587 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #473582 - Flags: review? → review?(nrthomas)
(Assignee)

Updated

7 years ago
Attachment #473585 - Flags: review? → review?(nrthomas)
(Assignee)

Updated

7 years ago
Attachment #473586 - Flags: review? → review?(nrthomas)
(Assignee)

Updated

7 years ago
Attachment #473587 - Flags: review? → review?(nrthomas)
Comment on attachment 473585 [details] [diff] [review]
Remove the unwrap shell script [mozilla-central]

Just ask for approval for all the branches on this patch.
Attachment #473585 - Flags: review?(nrthomas) → review+

Updated

7 years ago
Attachment #473582 - Flags: review?(nrthomas) → review+

Updated

7 years ago
Attachment #473586 - Attachment is obsolete: true
Attachment #473586 - Flags: review?(nrthomas)

Updated

7 years ago
Attachment #473587 - Attachment is obsolete: true
Attachment #473587 - Flags: review?(nrthomas)
(Assignee)

Comment 10

7 years ago
Comment on attachment 473582 [details] [diff] [review]
Use perl script to unwrap mars for nightlies

http://hg.mozilla.org/build/buildbotcustom/rev/a70b38b40088
Attachment #473582 - Flags: checked-in+
(Assignee)

Comment 11

7 years ago
Comment on attachment 473585 [details] [diff] [review]
Remove the unwrap shell script [mozilla-central]

This is a pure script removal, is NPOTB, and I can kill my own builds immediately after landing to prevent tying up machines.
Attachment #473585 - Flags: approval2.0?
Attachment #473585 - Flags: approval1.9.2.11?
Attachment #473585 - Flags: approval1.9.1.14?

Updated

7 years ago
Attachment #473585 - Flags: approval1.9.2.11?
Attachment #473585 - Flags: approval1.9.2.11+
Attachment #473585 - Flags: approval1.9.1.14?
Attachment #473585 - Flags: approval1.9.1.14+
"approval2.0+" granted in email.

> On 9/22/10 7:18 PM, Mike Beltzner wrote:
>> Fine with me.
>>
>> John O'Duinn <joduinn@mozilla.com> wrote:
>> hi;
>> This is NPOTB - can we land this, or do we need approval?
>>
Flags: needs-reconfig+
The portion of this bug that required a reconfig already landed. Removing needs-reconfig+ -- coop, I'll leave it to you to land the remaining patch in mozilla-*
Flags: needs-reconfig+
Comment on attachment 473585 [details] [diff] [review]
Remove the unwrap shell script [mozilla-central]

Missed the 1.9.2.11/1.9.1.14 releases
Attachment #473585 - Flags: approval1.9.2.11-
Attachment #473585 - Flags: approval1.9.2.11+
Attachment #473585 - Flags: approval1.9.1.14-
Attachment #473585 - Flags: approval1.9.1.14+
(Assignee)

Comment 15

7 years ago
Comment on attachment 473585 [details] [diff] [review]
Remove the unwrap shell script [mozilla-central]

Try to get on the next release train now that I'm back from vacation.
Attachment #473585 - Flags: approval1.9.2.12?
Attachment #473585 - Flags: approval1.9.1.15?
Comment on attachment 473585 [details] [diff] [review]
Remove the unwrap shell script [mozilla-central]

Approved for 1.9.2.12 and 1.9.1.15, a=dveditz for release-drivers

Landing sooner than later in the release would be appreciated.
Attachment #473585 - Flags: approval1.9.2.12?
Attachment #473585 - Flags: approval1.9.2.12+
Attachment #473585 - Flags: approval1.9.1.15?
Attachment #473585 - Flags: approval1.9.1.15+
(Assignee)

Comment 17

7 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7aeadba259be
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5bb0828aefe6

NPOTB, so triggered builds were canceled immediately.
status1.9.1: --- → .15-fixed
status1.9.2: --- → .12-fixed
(Assignee)

Comment 18

7 years ago
Comment on attachment 473585 [details] [diff] [review]
Remove the unwrap shell script [mozilla-central]

Removing approval request. This is NPOTB.
Attachment #473585 - Flags: approval2.0?
(Assignee)

Comment 19

7 years ago
Comment on attachment 473585 [details] [diff] [review]
Remove the unwrap shell script [mozilla-central]

http://hg.mozilla.org/mozilla-central/rev/e68b8f1399bd
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
This removal broke the SeaMonkey nightly tinderboxen:
bash -c /builds/slave/comm-central-trunk-linux64-nightly/build/mozilla/tools/update-packaging/unwrap_full_update.sh ../dist/update/seamonkey-2.1b2pre.en-US.linux-x86_64.complete.mar

What should this command be replaced with? The perl version of that script?
Oh nevermind, guess we just need to apply that patch to our config.
Blocks: 604752
Comment on attachment 473582 [details] [diff] [review]
Use perl script to unwrap mars for nightlies

http://hg.mozilla.org/build/buildbotcustom/rev/70e4b33de199
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.