327077 - Implement a way to get all the components with a given default assignee (owner) and/or default qacontact

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Reed Loden [:reed]]

Both timeless and myself have recently had to search all the products and components shown through describecomponents.cgi to find where a specific account is a default assignee/qacontact. There needs to be a better way to search for this instead of looking at each individual component.

Comment 1

[Paul]

*** Bug 349008 has been marked as a duplicate of this bug. ***

Comment 2

[Frédéric Buclin]

we are in "soft freeze" mode for 3.0.

Comment 3

[Kevin Benton]

It would also be helpful if users could change that role from the search results as well.  So if [e-mail] leaves the company and [e-mail] is taking over his duties, it would be very helpful if there were a simple way to change responsibilities from John to Fred with minimal input from the admin.

Comment 4

[Frédéric Buclin]

Attachment: patch, v1

Comment 5

[Olav Vitters]

Comment on attachment 260636 [details] [diff] [review]
patch, v1

>Index: template/en/default/admin/users/responsibilities.html.tmpl

Yes, it works. However, I do not like the layout. I get stuff like:

    * Default Assignee and Default QA Contact for storage:applet
    * Default Assignee and Default QA Contact for gnome-blog:Blog Applet
    * Default Assignee and Default QA Contact for storage:General
    * Default Assignee and Default QA Contact for storage:libmrs
    * Default Assignee and Default QA Contact for storage:libmrs-converter
    * Default Assignee and Default QA Contact for storage:libstorage-nl
    * Default Assignee and Default QA Contact for storage:libstorage-translators
    * Default Assignee and Default QA Contact for storage:PET
    * Default Assignee and Default QA Contact for storage:storage-store
    * Default Assignee and Default QA Contact for gnome-themes:theme-crux
    * Default Assignee and Default QA Contact for gnome-themes:theme-oceandream
    * Default Assignee for gnome-themes:theme-simple
    * Default Assignee and Default QA Contact for gnome-themes:theme-smokeyblue
    * Default Assignee and Default QA Contact for storage:VFS

First of all, why aren't we using a table for this (with some kind of checkmark for Default Assignee and Default QA columns)? Secondly, please sort first on product name, then component. In the table I'd ideally like a column for product, then for component. Ideally the product would span the number of components the user is responsible for. For extra points, I'd like the components cell to be blank if the user is reponsible for all components within a product.

Comment 6

[Frédéric Buclin]

Attachment: patch, v2

I fixed all bkor's review comments (except the last one about mentioning when the user is involved in all components of a product).

Comment 7

[Frédéric Buclin]

Attachment: screenshot with patch v2 applied

Nice, isn't it? ;)

Comment 8

[Olav Vitters]

Comment on attachment 264188 [details] [diff] [review]
patch, v2

>Index: Bugzilla/User.pm

>@@ -917,14 +917,33 @@ sub product_responsibilities {

>+    my $components = Bugzilla::Component->new_from_list(\@comp_ids);
>+
>+    my @prod_list;
>+    # @$products is already sorted alphabetically.
>+    foreach my $prod (@$products) {
>+        # We use @components instead of $prod->components because we only want
>+        # components where the user is either the default assignee or QA contact.
>+        push(@prod_list, {product    => $prod,
>+                          components => [grep {$_->product_id == $prod->id} @$components]});

Nit: This is slow. Imagine if someone is responsible for 800 components in 20 products; for each product you'd filter the 800 components again. Probably won't happen that often in reality though.

Comment 9

[Frédéric Buclin]

Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.152; previous revision: 1.151
done
Checking in skins/standard/editusers.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/editusers.css,v  <--  editusers.css
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.100; previous revision: 1.99
done
Checking in template/en/default/admin/users/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/confirm-delete.html.tmpl,v  <--  confirm-delete.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Checking in template/en/default/admin/users/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.10; previous revision: 1.9
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/responsibilities.html.tmpl,v
done
Checking in template/en/default/admin/users/responsibilities.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/responsibilities.html.tmpl,v  <--  responsibilities.html.tmpl
initial revision: 1.1
done

Comment 10

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.2 in a patch on bug 432331.