Closed Bug 327206 Opened 20 years ago Closed 20 years ago

bms.getFolderReadonly(folder.folderId) doesn't agree with folder.childrenReadOnly for "Latest Headlines" when iterating through bookmarks tree

Categories

(Firefox :: Bookmarks & History, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 2 alpha2

People

(Reporter: mozilla, Assigned: brettw)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

When navigating a query result that returns the bookmarks tree, folder.childrenReadOnly==false and _bms.getFolderReadonly(folder.folderId)==true when "folder" is a nsINavHistoryFolderResultNode representing the "Latest Headlines" livemark folder. These two values should be in agreement.
This is in the result nodes so probably my department.
Assignee: annie.sullivan → brettw
Attached patch Patch (obsolete) — — Splinter Review
Attachment #213634 - Flags: review?(annie.sullivan)
Attachment #213634 - Flags: review?(annie.sullivan) → review+
Attached patch Working patch — — Splinter Review
This patch actually works correctly. Getting the folder type in the constructor wasn't working properly because of some conflict in DB usage. So now folders implement their own getter for readonly and just pass it through to the bookmark service.
Attachment #213634 - Attachment is obsolete: true
Attachment #213915 - Flags: review?(annie.sullivan)
Attachment #213915 - Flags: review?(annie.sullivan) → review+
On branch and trunk
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: