327246 - [FIX]Make sure nsNodeInfoManagers always have a principal

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

Once bug 326506 lands, we can make nsNodeInfoManager always have a principal, falling back to null principal if nothing is set or on OOM, etc.

I'd like to do this in two steps:

1)  Do the nsNodeInfoManager part and land it; evaluate perf impact, if any.
2)  Rename GetNodePrincipal() to NodePrincipal() and simplify callers as needed.

Let me know if you'd prefer separate bugs on the two steps, ok?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Step 1

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 216986 [details] [diff] [review]
Step 1

r+sr=jst

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Step 2 for checkin

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Step 2 diff -w for review

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Step 2 for checkin, updated to tip

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Step 2 diff -w for review, updated to tip

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Step 2 updated to tip again.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fixed.