Closed Bug 327246 Opened 17 years ago Closed 16 years ago

[FIX]Make sure nsNodeInfoManagers always have a principal

Categories

(Core :: DOM: Core & HTML, defect, P1)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(2 files, 4 obsolete files)

Step 1
3.67 KB, patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review
Step 2 updated to tip again.
79.06 KB, patch
Details | Diff | Splinter Review 
Once bug 326506 lands, we can make nsNodeInfoManager always have a principal, falling back to null principal if nothing is set or on OOM, etc.

I'd like to do this in two steps:

1)  Do the nsNodeInfoManager part and land it; evaluate perf impact, if any.
2)  Rename GetNodePrincipal() to NodePrincipal() and simplify callers as needed.

Let me know if you'd prefer separate bugs on the two steps, ok?
Blocks: 308339
Attached patch Step 1 — — Splinter Review
Attachment #216986 - Flags: superreview?(jst)
Attachment #216986 - Flags: review?(jst)
Priority: -- → P1
Summary: Make sure nsNodeInfoManagers always have a principal → [FIX]Make sure nsNodeInfoManagers always have a principal
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 216986 [details] [diff] [review]
Step 1

r+sr=jst
Attachment #216986 - Flags: superreview?(jst)
Attachment #216986 - Flags: superreview+
Attachment #216986 - Flags: review?(jst)
Attachment #216986 - Flags: review+
Attached patch Step 2 for checkin (obsolete) — — Splinter Review
Attached patch Step 2 diff -w for review (obsolete) — — Splinter Review
Attachment #217111 - Flags: superreview?(jst)
Attachment #217111 - Flags: review?(jst)
Attachment #217109 - Attachment is obsolete: true
Attachment #217111 - Attachment is obsolete: true
Attachment #217111 - Flags: superreview?(jst)
Attachment #217111 - Flags: review?(jst)
Attachment #219797 - Flags: superreview?(bugmail)
Attachment #219797 - Flags: review?(bugmail)
Attachment #219797 - Flags: superreview?(bugmail)
Attachment #219797 - Flags: superreview+
Attachment #219797 - Flags: review?(bugmail)
Attachment #219797 - Flags: review+
Attachment #219794 - Attachment is obsolete: true
Attachment #219797 - Attachment is obsolete: true
Fixed.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.