327347 - Places search box does not have an accessible name

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Mark Pilgrim (inactive)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060214 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060214 Firefox/1.6a1

The Places search box does not expose an accessible name to assistive technologies.  By contrast, the main web search box has an accessible name of "Search".

Reproducible: Always

Steps to Reproduce:
1. Open Inspect32.exe
2. Open Places
3. Set focus to Places search box


Actual Results:  
Inspect32 shows accessible name = ""

Expected Results:  
Inspect32 shows a useful accessible name, such as "Search bookmarks and history" (if that option is selected) or "Search <collection name>" if "Current collection only" is selected.

Comment 1

[:Gijs (he/him)]

Attachment: Add label attribute equivalent to gray text

So this adds a label attribute which keeps the right value. Tested with inspect32, and this does the trick.



==
I should note that I've noticed the grey text doesn't update until you use the Edit menu to do a folder-specific search - after which it updates for each folder you select. Pretty sure that is a bug, will double-check and file afterwards, if it doesn't exist already.

Comment 2

[Asaf Romano (gone)]

Comment on attachment 279621 [details] [diff] [review]
Add label attribute equivalent to gray text

r=mano

Comment 3

[:Gijs (he/him)]

Comment on attachment 279621 [details] [diff] [review]
Add label attribute equivalent to gray text

This is low-to-zero-risk, and a boon for a11y. Asking for approval...

Comment 4

[:Gijs (he/him)]

Checking in mozilla/browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.108; previous revision: 1.107
done

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv