Note: There are a few cases of duplicates in user autocompletion which are being worked on.

createSVGAngle isn't implemented

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Robert Longson, Assigned: Robert Longson)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

12 years ago
similar to bug 264832 which did createSVGNumber/Length
(Assignee)

Comment 1

12 years ago
Created attachment 212097 [details] [diff] [review]
implement createSVGAngle
Assignee: general → longsonr
Status: NEW → ASSIGNED
Attachment #212097 - Flags: review?(tor)
(Assignee)

Comment 2

12 years ago
Created attachment 212098 [details]
testcase

click on the line and the marker will reorient.

N.B. you will need to have the patch to bug 325728 for the testcase to work as marker orient changes are not handled properly otherwise.

Comment 3

12 years ago
It seems we have the nsISVGAngle interface floating around for no particular reason.  Would probably be cleaner to remove that interface and use nsIDOMSVGAngle as the passed type.
(Assignee)

Comment 4

12 years ago
Created attachment 212206 [details] [diff] [review]
review comments and cleanup of nsSVGAngle code

Additionally nsISVGAngle.h should be removed when this patch is checked in.
Attachment #212097 - Attachment is obsolete: true
Attachment #212206 - Flags: review?(tor)
Attachment #212097 - Flags: review?(tor)
(Assignee)

Updated

12 years ago
Blocks: 325728

Updated

12 years ago
Attachment #212206 - Flags: review?(tor) → review+
(Assignee)

Updated

12 years ago
Attachment #212206 - Flags: superreview?(roc)
Attachment #212206 - Flags: superreview?(roc) → superreview+

Comment 5

12 years ago
Checked in for Robert.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.