Last Comment Bug 327437 - createSVGAngle isn't implemented
: createSVGAngle isn't implemented
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Robert Longson
: Hixie (not reading bugmail)
Mentors:
Depends on:
Blocks: 325728
  Show dependency treegraph
 
Reported: 2006-02-16 02:17 PST by Robert Longson
Modified: 2006-02-22 02:26 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
implement createSVGAngle (1.53 KB, patch)
2006-02-16 02:17 PST, Robert Longson
no flags Details | Diff | Splinter Review
testcase (1.16 KB, image/svg+xml)
2006-02-16 02:20 PST, Robert Longson
no flags Details
review comments and cleanup of nsSVGAngle code (9.17 KB, patch)
2006-02-17 04:19 PST, Robert Longson
tor: review+
roc: superreview+
Details | Diff | Splinter Review

Description Robert Longson 2006-02-16 02:17:11 PST
similar to bug 264832 which did createSVGNumber/Length
Comment 1 Robert Longson 2006-02-16 02:17:53 PST
Created attachment 212097 [details] [diff] [review]
implement createSVGAngle
Comment 2 Robert Longson 2006-02-16 02:20:21 PST
Created attachment 212098 [details]
testcase

click on the line and the marker will reorient.

N.B. you will need to have the patch to bug 325728 for the testcase to work as marker orient changes are not handled properly otherwise.
Comment 3 tor 2006-02-16 15:26:17 PST
It seems we have the nsISVGAngle interface floating around for no particular reason.  Would probably be cleaner to remove that interface and use nsIDOMSVGAngle as the passed type.
Comment 4 Robert Longson 2006-02-17 04:19:08 PST
Created attachment 212206 [details] [diff] [review]
review comments and cleanup of nsSVGAngle code

Additionally nsISVGAngle.h should be removed when this patch is checked in.
Comment 5 tor 2006-02-21 09:00:20 PST
Checked in for Robert.

Note You need to log in before you can comment on or make changes to this bug.