Simple change to allow the override of OBJDIR_NAME

RESOLVED FIXED in 4.7

Status

NSPR
NSPR
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
With a simple change to NSPR's configure script,
one can override OBJDIR_NAME on the gmake command
line, like this:

gmake OBJDIR_NAME=linux.debug

A better but bigger fix is to not use the OBJDIR
variable at all.
(Assignee)

Comment 1

12 years ago
Created attachment 212158 [details] [diff] [review]
Proposed patch

Without this patch, an NSPR build with OBJDIR_NAME=linux.debug on
the gmake command line fails like this:

cd md; gmake export
gmake[4]: Entering directory `/home/wtchang/nss-tip/mozilla/nsprpub/linux.debug/
pr/include/md'
../../../config/linux.debug/nsinstall -R -m 444 ../../../../pr/include/md/_aix32
.cfg ../../../../pr/include/md/_aix64.cfg ../../../../pr/include/md/_beos.cfg ..
/../../../pr/include/md/_bsdi.cfg ../../../../pr/include/md/_darwin.cfg ../../..
/../pr/include/md/_dgux.cfg ../../../../pr/include/md/_freebsd.cfg ../../../../p
r/include/md/_hpux32.cfg ../../../../pr/include/md/_hpux64.cfg ../../../../pr/in
clude/md/_irix32.cfg ../../../../pr/include/md/_irix64.cfg ../../../../pr/includ
e/md/_linux.cfg ../../../../pr/include/md/_ncr.cfg ../../../../pr/include/md/_ne
c.cfg ../../../../pr/include/md/_netbsd.cfg ../../../../pr/include/md/_nextstep.
cfg ../../../../pr/include/md/_nto.cfg ../../../../pr/include/md/_openbsd.cfg ..
/../../../pr/include/md/_openvms.cfg ../../../../pr/include/md/_os2.cfg ../../..
/../pr/include/md/_osf1.cfg ../../../../pr/include/md/_qnx.cfg ../../../../pr/in
clude/md/_reliantunix.cfg ../../../../pr/include/md/_rhapsody.cfg ../../../../pr
/include/md/_riscos.cfg ../../../../pr/include/md/_scoos.cfg ../../../../pr/incl
ude/md/_solaris.cfg ../../../../pr/include/md/_sony.cfg ../../../../pr/include/m
d/_sunos4.cfg ../../../../pr/include/md/_unixware7.cfg ../../../../pr/include/md
/_unixware.cfg ../../../../pr/include/md/_win16.cfg ../../../../pr/include/md/_w
in95.cfg ../../../../pr/include/md/_winnt.cfg /home/wtchang/nss-tip/mozilla/secu
rity/nss/../../dist/linux.debug/include/md
gmake[4]: ../../../config/linux.debug/nsinstall: Command not found
gmake[4]: *** [export] Error 127
gmake[4]: Leaving directory `/home/wtchang/nss-tip/mozilla/nsprpub/linux.debug/p
r/include/md'
Attachment #212158 - Flags: review?(cls)

Updated

12 years ago
Attachment #212158 - Flags: review?(cls) → review+
(Assignee)

Comment 2

12 years ago
I checked in the patch on the NSPR trunk (NSPR 4.7) and
the NSPRPUB_PRE_4_2_CLIENT_BRANCH (mozilla 1.9 alpha).

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.211; previous revision: 1.210
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.213; previous revision: 1.212
done

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.78.2.130; previous revision: 1.78.2.129
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.83.2.127; previous revision: 1.83.2.126
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.7
You need to log in before you can comment on or make changes to this bug.