327594 - need to construct native menus on window load

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Josh Aas]

Right now, we delay menu construction (including the creation of native menu
items) until a menu is selected. This is not good because in order for keyboard
commands to work, native menu items need to be created. This patch causes all
menus and their submenus to get constructed when the menu bar is. It works
because when the top-level menus are created, they call MenuConstruct.
MenuConstruct creates submenus, and during their creation they call
MenuConstruct. This goes on until all menus and their submenus have been
constructed. Voila.

Comment 1

[Josh Aas]

Attachment: fix, v1.1

Fixes the problem and removes a lot of unnecessary help menu code. It was probably left over from classic Mac OS.

Comment 2

[Mark Mentovai]

Would you mind adding a comment here saying that this is only around to implement the pure virtual function that only exists to support Carbon widgets, and that it can be removed once Carbon widgets are dead for real?
 
 NS_IMETHODIMP nsMenuX::IsHelpMenu(PRBool* aIsHelpMenu)
 {
   NS_ENSURE_ARG_POINTER(aIsHelpMenu);
-  *aIsHelpMenu = mIsHelpMenu;
+  *aIsHelpMenu = PR_FALSE;
   return NS_OK;
 }

You can also kill the IsHelpMenu call in nsMenuBarX.

Comment 3

[Josh Aas]

Fixed on trunk.