nsIXMLHTTPRequest class not included in MozillaInterfaces.jar

RESOLVED FIXED

Status

Core Graveyard
Java to XPCOM Bridge
RESOLVED FIXED
12 years ago
3 years ago

People

(Reporter: jhp (no longer active), Assigned: jhp (no longer active))

Tracking

({fixed1.8.0.2, fixed1.8.1})

Trunk
fixed1.8.0.2, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nvn-dl])

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Someone noticed that nsIXMLHTTPRequest.class is not in MozillaInterfaces.jar from XULRunner 1.8.0.1, but is included in the one from the XULRunner trunk.

It looks like this is a result of the order in which directories are processed in the top level Makefile.  The 'extensions/java' dir is in tier_50, but the remaining extensions (such as xmlextras, to which nsIXMLHTTPRequest.idl belongs) are handled in tier_99.

This is somewhat better on the trunk, since many of the main extensions are now in tier_9 (before 'extensions/java'), but some extensions still come later.

The GenerateJavaInterfaces util uses nsInterfaceInfoManager to get all of the available interfaces, and it will only read from the available .xpt files.  So this step needs to come after all the IDL files have been processed.
(Assignee)

Comment 1

12 years ago
Created attachment 212516 [details] [diff] [review]
patch

This patch fixes it, but is more of a band-aid.  In the long run, we should probably move the interface generation and any other jars that depend on it to their own sub-directory.
Attachment #212516 - Flags: review?(benjamin)
Comment on attachment 212516 [details] [diff] [review]
patch

This sucks in general: we should be hooking into xpidl and the XPIDLSRCS targets in rules.mk and generating on the fly.
Attachment #212516 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

12 years ago
That still won't fix this, since at the end, we need to compile the Java classes.  So we would still need to do something after all of the IDL files have been parsed.
(Assignee)

Comment 4

12 years ago
Comment on attachment 212516 [details] [diff] [review]
patch

We should get this in for XULRunner 1.8.0.2.
Attachment #212516 - Flags: approval1.8.0.2?
Comment on attachment 212516 [details] [diff] [review]
patch

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #212516 - Flags: approval1.8.0.2? → approval1.8.0.2+
(Assignee)

Comment 6

12 years ago
Checked in to trunk.
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Keywords: fixed1.8.0.2, fixed1.8.1

Updated

12 years ago
Whiteboard: [nvn-dl]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.