327669 - Viewer demos links in Debug menu

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Rafal Likus]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.1) Gecko/20060130 SeaMonkey/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.1) Gecko/20060130 SeaMonkey/1.0

Old viewer samples from the tree are removed, so links needs to be updated.
They were used in debug code - Debug menu.

Remove:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-02-08+08%3A49&maxdate=2006-02-08+08%3A51&cvsroot=%2Fcvsroot

Reproducible: Always

Steps to Reproduce:

Comment 1

[Rafal Likus]

Attachment: 1st version of patch

1st version of patch.

Comment 2

[Rafal Likus]

Attachment: 2nd version of patch

2 version of patch.
This two links are direct. In 1st patch links are redirecting to them

+        <menuitem label="#14 XML Sorting" oncommand="loadURI('http://www.mozilla.org/newlayout/xml/debugdemos/books/books.xml');"/>
+        <menuitem label="#15 XML IRS" oncommand="loadURI('http://www.mozilla.org/newlayout/xml/debugdemos/tocdemo/rights.xml');"/>


instead of this from 1st patch:

+        <menuitem label="#14 XML Sorting" oncommand="loadURI('http://www.mozilla.org/newlayout/samples/test14.html');"/>
+        <menuitem label="#15 XML IRS" oncommand="loadURI('http://www.mozilla.org/newlayout/samples/test15.html');"/>

Comment 3

[[e-mail]]

Comment on attachment 212259 [details] [diff] [review]
1st version of patch

Nit: items #1 to #9 have double spaces before oncommand=; presumably they date from a time when the menuitems only had numbers?

Comment 4

[Rafal Likus]

So what? Make another patch without these double spaces?
I am greenhorn in such process so I do not know.

Comment 5

[[e-mail]]

No, whomever you persuade to check in can easily fix them.

Comment 6

[Andrew Schultz]

I landed this on trunk (without the double-spaces).  I'm not sure why it needs to go on the branch since the debug menu is going away soon.

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 212259 [details] [diff] [review]
1st version of patch

Revoking a= so ajschult's queries are happier.