selectDialog's label can't contain line breaks (displays only the last line)

NEW
Unassigned

Status

()

13 years ago
12 years ago

People

(Reporter: zeniko, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
Per comment, selectDialog's label should be able to contain several lines. However, due to a buggy algorithm only the last line is displayed. And AFAICT, labels can't contain more than one line anyway.

A fix should either simply set the value without any transformation or better use a description instead of a label (which does support line breaks).
(Reporter)

Comment 1

13 years ago
Created attachment 212292 [details] [diff] [review]
use one description per text line
Assignee: nobody → zeniko
Status: NEW → ASSIGNED
Attachment #212292 - Flags: first-review?(mconnor)
(Reporter)

Updated

12 years ago
Attachment #212292 - Flags: first-review?(mconnor) → first-review?(gavin.sharp)
Comment on attachment 212292 [details] [diff] [review]
use one description per text line

I think this should just use a description with -moz-pre-wrap, like commonDialog.xul.
Attachment #212292 - Flags: first-review?(gavin.sharp) → first-review-
(Reporter)

Comment 3

12 years ago
Martijn: Gavin would like about the same changes you've already made for commonDialog in bug 317334 for selectDialog in this bug as well. Interested?
Assignee: zeniko → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.