XPCNativeWrapper.prototype() crashes [@ JS_GetClass]

VERIFIED FIXED in mozilla1.9alpha1

Status

()

Core
XPConnect
P1
critical
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: Jesse Ruderman, Assigned: mrbkap)

Tracking

(Blocks: 1 bug, {crash, testcase})

Trunk
mozilla1.9alpha1
crash, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
 
(Reporter)

Comment 1

12 years ago
Created attachment 212273 [details]
testcase
(Assignee)

Updated

12 years ago
OS: MacOS X → All
Priority: -- → P1
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.9alpha
(Assignee)

Comment 2

12 years ago
Created attachment 212287 [details] [diff] [review]
Proposed fix

Calling XPCNativeWrapper.prototype() should be a no-op and is the only time that we'll get into a class's call hook with an obj not of that class.
Assignee: dbradley → mrbkap
Status: NEW → ASSIGNED
Attachment #212287 - Flags: superreview?(bzbarsky)
Attachment #212287 - Flags: review?(brendan)
Comment on attachment 212287 [details] [diff] [review]
Proposed fix

r=me if you use NS_WARNING or whatever the non-fatal form is.  It seems easy to reparent prototype and call it with a non-function |this| parameter, and we shouldn't count on non-fatal assertions.

/be
Attachment #212287 - Flags: review?(brendan) → review+
Attachment #212287 - Flags: superreview?(bzbarsky) → superreview+
(Assignee)

Comment 4

12 years ago
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Verified FIXED using SeaMonkey trunk 2006-02-22-10 on Windows XP with the testcase at: https://bugzilla.mozilla.org/attachment.cgi?id=212273&action=view
Status: RESOLVED → VERIFIED
Crash Signature: [@ JS_GetClass]
You need to log in before you can comment on or make changes to this bug.