Margins on tabbrowser from places.css

RESOLVED FIXED in Firefox 2 alpha2

Status

()

P3
normal
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: kbrosnan, Assigned: annie.sullivan)

Tracking

({fixed1.8.1})

Trunk
Firefox 2 alpha2
x86
Windows XP
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
The right hand scrollbar is not flush against the edge of the window, there is a space of a few millimeters the same is true for the bottom, the space in the top is between the tab bar and the places bar. The left side does not have a space. It looks like it is appcontent that has the extra space. The tab bar is also white.
(Reporter)

Comment 1

13 years ago
My build checkout start: Fri Feb 17 19:47:07 EST 2006 (16:47 PST). The offical build from the 16th did not have this issue.
Annie, this is you from bug 318052, no? You added places.css to browserShim.xul, which makes the #content selector for the Places page also apply to the tabbrowser, which also has id="content", so now the tabbrowser has 6-7px margins.
Blocks: 318052
Summary: extra space in id=appcontent and the tab bar is white → Margins on tabbrowser from places.css
will be fixed by move to external window in a2
Assignee: nobody → bugs
Priority: -- → P3
Target Milestone: --- → Firefox 2 alpha2
(Assignee)

Comment 4

13 years ago
Created attachment 212636 [details] [diff] [review]
Moves the styles for the personal toolbar into the browser shim stylesheet

I think Phil is right that the toolbar styles don't belong in places.css, the styles in that file are for the places page.  This patch moves them to the browser shim.
Assignee: bugs → annie.sullivan
Status: NEW → ASSIGNED
Attachment #212636 - Flags: review?(bugs)
Comment on attachment 212636 [details] [diff] [review]
Moves the styles for the personal toolbar into the browser shim stylesheet

r=ben@mozilla.org
Attachment #212636 - Flags: review?(bugs) → review+
(Assignee)

Updated

13 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Keywords: fixed1.8.1
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.