327806 - ChatZilla should work on Flock

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[:Gijs (he/him)]

As in summary. Patch coming up (hopefully).

Comment 1

[:Gijs (he/him)]

Attachment: Patch

This patch:
- Adds "Flock" as a possible value for the host app.
- Makes some logic as to where to find icons cope with Flock.
- Changes the unknown host message to use the uid found with app.ID. This means that this will work sub-optimally on applications that don't have nsIXULAppInfo. I don't know if this is something we should worry about. Personally, I think we shouldn't, as I don't know of any app we don't currently recognize, that doesn't use nsIXULAppInfo and that's recent enough to be usable for users.

Comment 2

[Rob Marshall [tH]]

Attachment: slightly updated patch

Hannibal asked me to update this since he's busy.
Fixes indenting in install.rdf, makes the same change to the locale install.rdf, and changes the Flock compatability to work on recently released versions.

Comment 3

[James Ross]

Comment on attachment 212381 [details] [diff] [review]
slightly updated patch

r=silver

A followup patch is needed to set client.unknownUID for the case where we are using getBrowserURL() - it doesn't matter that we call it a UID, but we really should show what we tried to identify.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/extensions/irc/xpi/locale-resources/install.rdf; new revision: 1.2;
mozilla/extensions/irc/xpi/resources/install.rdf; new revision: 1.5;
mozilla/extensions/irc/xul/content/static.js; new revision: 1.185;
mozilla/extensions/irc/xul/locale/en-US/chatzilla.properties; new revision: 1.102;

Comment 5

[Rob Marshall [tH]]

Attachment: set unknownUID to browser URL

Comment 6

[James Ross]

Checked in --> FIXED.

Comment 7

[:Gijs (he/him)]

Assignee fun.