ChatZilla should work on Flock

RESOLVED FIXED

Status

Other Applications
ChatZilla
--
enhancement
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Gijs, Assigned: Rob Marshall [tH])

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.71])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

13 years ago
As in summary. Patch coming up (hopefully).
(Reporter)

Comment 1

13 years ago
Created attachment 212379 [details] [diff] [review]
Patch

This patch:
- Adds "Flock" as a possible value for the host app.
- Makes some logic as to where to find icons cope with Flock.
- Changes the unknown host message to use the uid found with app.ID. This means that this will work sub-optimally on applications that don't have nsIXULAppInfo. I don't know if this is something we should worry about. Personally, I think we shouldn't, as I don't know of any app we don't currently recognize, that doesn't use nsIXULAppInfo and that's recent enough to be usable for users.
Attachment #212379 - Flags: review?(silver)
(Reporter)

Updated

13 years ago
Assignee: rginda → gijskruitbosch+bugs
(Assignee)

Comment 2

13 years ago
Created attachment 212381 [details] [diff] [review]
slightly updated patch

Hannibal asked me to update this since he's busy.
Fixes indenting in install.rdf, makes the same change to the locale install.rdf, and changes the Flock compatability to work on recently released versions.
Attachment #212379 - Attachment is obsolete: true
Attachment #212381 - Flags: review?(silver)
Attachment #212379 - Flags: review?(silver)

Comment 3

13 years ago
Comment on attachment 212381 [details] [diff] [review]
slightly updated patch

r=silver

A followup patch is needed to set client.unknownUID for the case where we are using getBrowserURL() - it doesn't matter that we call it a UID, but we really should show what we tried to identify.
Attachment #212381 - Flags: review?(silver) → review+
mozilla/extensions/irc/xpi/locale-resources/install.rdf; new revision: 1.2;
mozilla/extensions/irc/xpi/resources/install.rdf; new revision: 1.5;
mozilla/extensions/irc/xul/content/static.js; new revision: 1.185;
mozilla/extensions/irc/xul/locale/en-US/chatzilla.properties; new revision: 1.102;
(Assignee)

Comment 5

13 years ago
Created attachment 212490 [details] [diff] [review]
set unknownUID to browser URL
Attachment #212490 - Flags: review?(silver)

Updated

13 years ago
Attachment #212490 - Flags: review?(silver) → review+

Comment 6

13 years ago
Checked in --> FIXED.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

13 years ago
Assignee fun.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

13 years ago
Assignee: gijskruitbosch+bugs → rdmsoft
Status: REOPENED → NEW
(Reporter)

Updated

13 years ago
Status: NEW → RESOLVED
Last Resolved: 13 years ago13 years ago
Resolution: --- → FIXED

Updated

13 years ago
Whiteboard: [cz-0.9.71]
You need to log in before you can comment on or make changes to this bug.