327818 - 0 days of history is still a lot

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Ria Klaassen (not reading all bugmail)]

Steps to reproduce:

1. Make a new profile and delete history.dat, bookmarks_history.sqlite and delete the contents of bookmarks.html.
2. Run Firefox with enabled Places, go to some sites with many links and open some hundreds in tabs. Set them all to multiple homepages (that the quickest ways I know to repeat the test).
3. Set Options > Privacy > History to 0 days and close Firefox.
4. Then inspect the bookmarks_history.sqlite.
5. Expected behaviour: there should be no visited urls.

Comment 1

[Ria Klaassen (not reading all bugmail)]

It just ignores the 0 days, also in next sessions.

Comment 2

[Brett Wilson]

*** Bug 329539 has been marked as a duplicate of this bug. ***

Comment 3

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060310 Firefox/1.6a1 ID:2006031014 [cairo]

this WFM after Bug 328598 landed
on exit my bookmarks_history.sqlite resized from 2Mb to 1.3Mb 

Comment 4

[Brett Wilson]

I think you are mistaken. I don't think we handle the 0-day case (no history) at all. I'm interested if you can verify (I haven't tested it yet, but I don't see any code for handling the case where it is 0).

Comment 5

[Peter van der Woude [:Peter6]]

(In reply to comment #4)
> I think you are mistaken. I don't think we handle the 0-day case (no history)
> at all. I'm interested if you can verify (I haven't tested it yet, but I don't
> see any code for handling the case where it is 0).
> 
Yeah, my bad, this isn't fixed

Comment 6

[Brett Wilson]

Attachment: Patch

Comment 7

[Brett Wilson]

Patch is on branch and trunk

Comment 8

[Ria Klaassen (not reading all bugmail)]

Hm, it is still the same.
It deletes the history in Places, but not in the .sqlite file.

Comment 9

[Brett Wilson]

It being gone from places means that it isn't there. If old history is still visible in the sqlite file, then that is bug 330332. You shouldn't see new history in the file. i.e. you should be able to set history to 0 days, visit some sites you've never been to before, and you won't see them in the file no matter what. Reopen with more information if you do (I just tested and it seems OK). I just filed bug 331985 for not storing favicons when history is disabled, because you will see those.

Comment 10

[Ria Klaassen (not reading all bugmail)]

It's not quite fixed. I set history to 0 days, restarted firefox, deleted all history and bookmarks files, did a few google searches for dog, cat and goat and after closing firefox and opening the sqlite file I saw this:

Åhttp://www.google.nl/search?q=dog+cat+goat&hl=nl&lr=&start=40&sa=N4  }http://www.google.nl/search?q=dog+cat+goat&hl=nl&lr=&start=30&sa=N3  5http://www.enchantedlearning.com/stories/rhyme/ladyfly/2   ùhttp://www.google.nl/search?q=dog+cat+goat&hl=nl&lr=&start=20&sa=N1   ±http://www.google.nl/search?q=dog+cat+goat&hl=nl&lr=&start=10&sa=N0   ihttp://www.google.nl/search?hl=nl&q=dog+cat+goat&btnG=Google+zoeken&meta=/   http://www.google.nl/.?
 )	http://www.google.nl/search?q=dog+cat+goat&hl=nl&lr=&start=40&sa=Nsearchln.elgoog.www.   d )	http://www.google.nl/search?q=dog+cat+goat&hl=nl&lr=&start=30&sa=Nsearchln.elgoog.www.

Comment 11

[Brett Wilson]

It looks like those URLs in the file are from the favicons (bug 331958). When you visit the page the favicon is store and is associated with the page. This means the page URL is also stored. The entry is deleted on shutdown because it has no visits (history is disabled), but, because of bug 330332, it doesn't get cleared from the file.

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv