327841 - Re-implement a failed favicon cache in the favicon service

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Brett Wilson]

The old favicon handling code maintained a cache of favicons that failed to load. This supposedly had a reasonable performance benefit on sites that had invalid or missing favicons.

This should be implemented in the new favicon service. There are some FIXMEs in nsFaviconService.cpp about this.

Comment 1

[Brett Wilson]

Attachment: Patch

This implements a failed favicon cache that keeps track of favicons that are invalid or otherwise fail to load. It is persisted for the browser session. This saves time when browsing sites that don't have a favicon because we don't try to load the nonexistant favicon for every page.

This also checks for bookmark redirects so that we update the bookmark entry when it redirects to another page that has a favicon. When we set a favicon, we ask the bookmark service if this is the destination of a bookmark (fast because this is based on an in-memory hashtable) and if so, then we also update that bookmarked URI.

This also re-enables caching of data. We keep the favicon data for a day before trying to reload it, which will save a lot of time copying the same data from cache to DB for every pageload.

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 213821 [details] [diff] [review]
Patch

>+  // failed favicon cache
>+  mFailedFavicons.Init(256);

check for out of memory

the 1-day recheck isn't ideal (i'd prefer if we could recheck on first access in a session and get immediate notification from the cache _during_ the session) but in the absence of those notifications this seems ok.

Comment 3

[Brett Wilson]

Attachment: Final patch with bugfixes

Comment 4

[Brett Wilson]

On branch and trunk

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv