327906 - Use generic element flags for controls

Status: RESOLVED WONTFIX

(Core Graveyard :: XForms, enhancement)

Description

[Allan Beaufour]

We are using a lot of space for our controls. We should just have one generic "mElementStates/Flags/whatever" var.

PRBools and BindAttrCount (32 bit, using max. 3 bits...):
http://lxr.mozilla.org/seamonkey/source/extensions/xforms/nsXFormsControlStub.h#163
repeat state could probably be incorporated too:
http://lxr.mozilla.org/seamonkey/source/extensions/xforms/nsXFormsDelegateStub.h#112

And probably more.

Should be fairly easy to do.

Comment 1

[Allan Beaufour]

Could include putting mControlType into "#ifdef DEBUG_smaug ... #endif" too, there's not really any reason for it to be there if not debugging.

Comment 2

[aaronr]

(In reply to comment #1)
> Could include putting mControlType into "#ifdef DEBUG_smaug ... #endif" too,
> there's not really any reason for it to be there if not debugging.
> 

fine with me, but surround it by a generic ifdef DEBUG then, please.  I tend to look at this data quite often when trying to track down bugs that wind in and out of XBL.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

RIP xforms