Closed Bug 327920 Opened 19 years ago Closed 17 years ago

templates using the newer syntax with multiple rules requires refvar to be ?uri

Categories

(Core :: XUL, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(1 file)

This is a simple patch, which I'll create after 326712 and other bugs are fixed. The issue is that the syntax: <query> <content uri="?start"/> ... </query> <rule>...</rule> doesn't set variable ?start properly. Not a regression though since it works properly for existing syntax forms.
Target Milestone: --- → mozilla1.9beta1
Attached patch Simple fixSplinter Review
Testcase at http://www.xulplanet.com/ndeakin/tests/xts/templates/rule-refvar-changed.xul The issue is that the uri="?start" doesn't get checked in the conditional block where there is a <query> and <rule>, so it defaults to ?uri rather than ?start. Add a call to DetermineRDFQueryRef as in the other two conditional blocks. Maybe peterv would like to review this.
Attachment #270017 - Flags: superreview?(peterv)
Attachment #270017 - Flags: review?(peterv)
Attachment #270017 - Flags: superreview?(peterv)
Attachment #270017 - Flags: superreview+
Attachment #270017 - Flags: review?(peterv)
Attachment #270017 - Flags: review+
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Added an automated test to my local version of 378893
Flags: in-testsuite-
This should get set to +, then, when those tests are committed.
Depends on: 378893
Flags: in-testsuite- → in-testsuite?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: