327943 - nsGrippyFrame probably isn't needed

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Neil Deakin]

The only use it has is to change the collapsed attribute state when clicked, but this could be done in XBL instead.

For toolkit, <grippy> is only used on Mac and even then the collapsing should happen on the splitter to be consistent with other Mac apps.

Comment 1

[Neil Deakin]

Attachment: Remove grippy frame

Neil, can you review the xbl parts, if you think this is a good idea

Comment 2

[[e-mail]]

Comment on attachment 212493 [details] [diff] [review]
Remove grippy frame

>+      <handler event="click">
This includes right and middle clicks. You probably want to use command instead. Also I believe our style is to use <![CDATA[ blocks for large handlers. r=me with these fixed.

>+            splitter.setAttribute("state", "open");
Intriguingly the splitter frame actually uses an empty string when you drag the splitter open, but I guess that's a separate bug. (Removing the attribute is obviously incorrect).

Comment 3

[Neil Deakin]

Comment on attachment 212493 [details] [diff] [review]
Remove grippy frame

roc, could you review the layout parts also?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Neil, this patch should be OK on the 1.8 branch, right? It would make mirroring checkins to toolkit/content/widgets easier. As is, splitter.xml would need to be ifdeffed if branch and trunk are synced.

Comment 5

[Neil Deakin]

(In reply to comment #4)
> Neil, this patch should be OK on the 1.8 branch, right? It would make mirroring
> checkins to toolkit/content/widgets easier. As is, splitter.xml would need to
> be ifdeffed if branch and trunk are synced.
> 

It should be OK.