Closed
Bug 327977
Opened 19 years ago
Closed 16 years ago
Password manager overwrites page data for password-only forms
Categories
(Toolkit :: Password Manager, defect)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: philor, Assigned: Dolske)
Details
Attachments
(1 file)
2.42 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Bug 235336 added remembering a password without a username, but that means we now have to consider the bug 270558 problem of overwriting data filled by the page for forms with just a password, without a reasonable solution I can see: right now, we overwrite whatever the page filled with our saved password, which will sometimes be right and sometimes wrong, but not overwriting would also sometimes be wrong, and we can't just attach an autocomplete widget that would offer to fill in "*******".
I'd just wontfix myself, but I'm hoping there's a solution I can't think of right now.
Comment 1•18 years ago
|
||
Are there sites or scenarios in which this matters? I can't think of any...
Reporter | ||
Comment 2•18 years ago
|
||
It's certainly possible to contrive one; I expect we'll find out whether or not anyone's been quite that odd once we actually ship something with the fix for bug 235336.
Assignee | ||
Comment 3•16 years ago
|
||
Assignee | ||
Updated•16 years ago
|
Target Milestone: --- → Firefox 3.1a1
Comment 4•16 years ago
|
||
Comment on attachment 329272 [details] [diff] [review]
Patch v.1
>diff --git a/toolkit/components/passwordmgr/test/test_basic_form_1pw.html b/toolkit/components/passwordmgr/test/test_basic_form_1pw.html
> function startTest() {
> todo(false, "Don't clobber prefilled differing password");
> //for (f = 15; f <= 18; f++) { checkUnmodifiedForm(f); }
> for (f = 19; f <= 26; f++) { checkForm(f, "testuser", "testpass"); }
> todo(false, "Don't clobber prefilled differing password");
> //for (f = 27; f <= 30; f++) { checkUnmodifiedForm(f); }
What about these?
Attachment #329272 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 5•16 years ago
|
||
(In reply to comment #4)
> What about these?
Those tests are checking for if we overwrite page data on username+password forms, which we currently do. The patch in bug 444515 will address that (and I guess enable these tests :)
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Assignee | ||
Comment 6•16 years ago
|
||
(Pushed in changeset 00f2aeb4b581)
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•