328039 - Wrong focus traversal order in "Allow Cookie?" sheet.

Status: RESOLVED DUPLICATE of bug 408576

(Camino Graveyard :: Accessibility, defect)

Description

[the Falcon]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060214 Camino/1.0
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060214 Camino/1.0

When you have the preference "Ask before accepting each cookie" and you visit a site that is not in your Exceptions List and it wants to set a cookie, you get the "Allow Cookie?" sheet. In this sheet, the focus is initially on the check box "Remember this decision?". Rather, the default focus should be on the Deny button, so that pressing the Return key will result in Allow and pressing the Space bar will result in Deny.
Further, from the initial focus on the check box, you have to press the Tab key twice to get to the Deny button, because pressing Tab once traverses the focus to the Allow button. The most intuitive focus traversal order when pressing Tab (for user that read left to right, top to bottom) would be check box > Deny > Allow > check box.


Reproducible: Always

Steps to Reproduce:
1. In Preferences > Privacy, make sure "Ask before accepting each cookie" is checked.
2. Go to a web site that is not in your Exceptions List but that does want to set cookies.
3. When the "Allow Cookie?" sheet appears, press the Tab key once.
4. Press the Tab key again.
5. Press the Space bar.

Actual Results:  
Step 3 makes the focus traverse from the check box to the Allow button.
Step 4 traverse the focus from the Allow button to the Deny button.
Step 5 activates the Deny button.

Expected Results:  
Initial focus should be on the Deny button so that you can press the Space bar immediately to Deny. With focus on the Deny button, pressing the Tab key should traverse the focus to the Allow button, while pressing Shift-Tab should traverse to the check box.

Comment 1

[Stuart Morgan]

Given that Esc aleady maps to Deny, why would it be better to have the initial focus there instead of on a control with no key equivalent?

Comment 2

[the Falcon]

Ah, I didn't know that Esc does that. Still, the current focus traversal order makes no sense to me. When the focus is on the check box, I would expect that pressing Tab traverses the focus to Deny; instead, it traverses to Allow. To me (as someone who reads from left to right), that's counterintuitive.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Chris, you should keep these issues in mind your session cookies sheet.

That said, I don't think that the current order is wrong given Stuart's comments (and that in non-checkboxed sheets, we always start on the right).

I think this is WONTFIX and we just make sure Chris doesn't give us a really odd order in the session cookie sheet.

Comment 4

[the Falcon]

(In reply to comment #3)
> That said, I don't think that the current order is wrong given Stuart's
> comments (and that in non-checkboxed sheets, we always start on the right).

Please also see my comment on bug 328048 over here: https://bugzilla.mozilla.org/show_bug.cgi?id=328048#c2
Basically, I argue that having the focus "always start on the right" is actually inconsistent with how most Apple apps do it.

Comment 5

[the Falcon]

Oh, and I would like to add that normal focus traversal in built-in dialogs on Mac OS X is also from left to right, top to bottom. Try the Save As file chooser, for example, in any app, including Camino.

Comment 6

[Chris Lawson (gone)]

Håkan, what's your take on the accessibility side of this? I think it'd be useful polish, but I also think it's going to be a giant pain in the ass, and we shouldn't worry about it too much.

Comment 7

[Håkan Waara]

Cancel ("Deny" in this case) is always mapped to Esc, so that's no problem. The focus order is a bit peculiar, so if someone's redoing the cookie sheet, that might worth spending 5 minutes to look at, but I don't think it's a big deal, other than for correctness/polish.

How is the cookie dialog laid out? Is it done programmatically in such a way that the automatic focus traversal is confused?

Comment 8

[Håkan Waara]

IIRC, there's a method to force a window/dialog to remap its focus order, that could be used as a hack fix. (recalculateResponderChain or something like that)