Support unification of bdate for multi-project builds

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Mark Mentovai, Assigned: Mark Mentovai)

Tracking

({fixed1.8.0.2, fixed1.8.1})

Trunk
PowerPC
Mac OS X
fixed1.8.0.2, fixed1.8.1
Points:
---
Bug Flags:
blocking1.8.0.2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nvn-dl])

Attachments

(1 attachment, 1 obsolete attachment)

2.19 KB, patch
Benjamin Smedberg
: approval-branch-1.8.1+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
Follow-up to bug 327823.

We need a way to set the bdate once to a single value that will be used for all projects in a multi-project build.  The architecture-specific halves of Mac universal binaries are built in multi-project builds and must have the same bdate.
(Assignee)

Comment 1

12 years ago
Created attachment 212622 [details] [diff] [review]
MOZ_UNIFY_BDATE
Attachment #212622 - Flags: review?(benjamin)

Comment 2

12 years ago
Comment on attachment 212622 [details] [diff] [review]
MOZ_UNIFY_BDATE

I would generally prefer

ifdef MOZ_UNIFY_BDATE
ifndef MOZ_BUILD_DATE
ifdef MOZ_BUILD_PROJECTS
...
endif
endif
endif

For readability. With that change r=me
Attachment #212622 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

12 years ago
Created attachment 212630 [details] [diff] [review]
As checked in

Addresses the review comments.
Attachment #212622 - Attachment is obsolete: true
Attachment #212630 - Flags: approval1.8.0.2?
Attachment #212630 - Flags: approval-branch-1.8.1?(benjamin)

Updated

12 years ago
Attachment #212630 - Flags: approval-branch-1.8.1?(benjamin) → approval-branch-1.8.1+
Flags: blocking1.8.0.2+
Comment on attachment 212630 [details] [diff] [review]
As checked in

approved for 180 branch, a=dveditz for drivers
Attachment #212630 - Flags: approval1.8.0.2? → approval1.8.0.2+
(Assignee)

Comment 5

12 years ago
Holding branch checkins for landing of dependency, bug 327823 (which is waiting on bug 307311).
(Assignee)

Comment 6

12 years ago
Checked in on trunk, 1.8, and 1.8.0 branches.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.0.2, fixed1.8.1
Resolution: --- → FIXED

Updated

12 years ago
Whiteboard: [nvn-dl]
You need to log in before you can comment on or make changes to this bug.