Closed Bug 328081 Opened 18 years ago Closed 18 years ago

Support unification of bdate for multi-project builds

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mark, Assigned: mark)

Details

(Keywords: fixed1.8.0.2, fixed1.8.1, Whiteboard: [nvn-dl])

Attachments

(1 file, 1 obsolete file)

As checked in
2.19 KB, patch
benjamin
: approval-branch-1.8.1+
dveditz
: approval1.8.0.2+
Details | Diff | Splinter Review 
Follow-up to bug 327823.

We need a way to set the bdate once to a single value that will be used for all projects in a multi-project build.  The architecture-specific halves of Mac universal binaries are built in multi-project builds and must have the same bdate.
Attached patch MOZ_UNIFY_BDATE (obsolete) — — Splinter Review 

        Attachment #212622 -
        Flags: review?(benjamin)

    
    

    
  
Comment on attachment 212622 [details] [diff] [review]
MOZ_UNIFY_BDATE

I would generally prefer

ifdef MOZ_UNIFY_BDATE
ifndef MOZ_BUILD_DATE
ifdef MOZ_BUILD_PROJECTS
...
endif
endif
endif

For readability. With that change r=me

        Attachment #212622 -
        Flags: review?(benjamin) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        As checked in
        — 
          — Splinter Review
      

    


  
Addresses the review comments.

        Attachment #212622 -
        Attachment is obsolete: true

        Attachment #212630 -
        Flags: approval1.8.0.2?

        Attachment #212630 -
        Flags: approval-branch-1.8.1?(benjamin)

    
  

        Attachment #212630 -
        Flags: approval-branch-1.8.1?(benjamin) → approval-branch-1.8.1+
Flags: blocking1.8.0.2+

    
    

    
  
Comment on attachment 212630 [details] [diff] [review]
As checked in

approved for 180 branch, a=dveditz for drivers

        Attachment #212630 -
        Flags: approval1.8.0.2? → approval1.8.0.2+

    
    

    
  
Holding branch checkins for landing of dependency, bug 327823 (which is waiting on bug 307311).

    
    

    
  
Checked in on trunk, 1.8, and 1.8.0 branches.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.0.2, 
          
            fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [nvn-dl]

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: