If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

move upload into xforms.xhtml

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
12 years ago
a year ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

({fixed1.8.0.4, fixed1.8.1})

Trunk
fixed1.8.0.4, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

10.42 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051212 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051212 Firefox/1.6a1

move upload into xforms.xhtml

Reproducible: Always

Updated

12 years ago
Assignee: aaronr → surkov

Updated

12 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 1

12 years ago
Created attachment 213223 [details] [diff] [review]
patch
Attachment #213223 - Flags: review?(allan)
(Assignee)

Updated

12 years ago
Attachment #213223 - Flags: review?(doronr)
(Assignee)

Updated

12 years ago
Attachment #213223 - Flags: review?(doronr)
(Assignee)

Updated

12 years ago
Attachment #213223 - Flags: review?(doronr)

Comment 2

12 years ago
Comment on attachment 213223 [details] [diff] [review]
patch

>-upload {
>-  -moz-binding: url('chrome://xforms/content/xforms.xml#xformswidget-upload-disabled');
>+html|*:root upload {
>+  -moz-binding: url('chrome://xforms/content/xforms-xhtml.xml#xformswidget-upload-disabled');
> }

html|*:root, what is that?
(Assignee)

Comment 3

12 years ago
(In reply to comment #2)

> 
> html|*:root, what is that?
> 

It means the upload control will be used only in xhtml documents and we should provide new widgets for other documents (like xul, svg or something else).

Updated

12 years ago
Attachment #213223 - Flags: review?(allan) → review+
(Assignee)

Comment 4

12 years ago
Created attachment 215974 [details] [diff] [review]
updated
Attachment #213223 - Attachment is obsolete: true
Attachment #215974 - Flags: review?(doronr)
Attachment #213223 - Flags: review?(doronr)

Comment 5

12 years ago
Comment on attachment 215974 [details] [diff] [review]
updated

>+      <handler event="keypress" keycode="VK_RETURN">
>+        switch (event.originalTarget.getAttribute("anonid")) {
>+        case "browse_button": case "clear_button":
>+          this.dispatchDOMUIEvent('DOMActivate');
>+          break;
>+        }

I prefer:

 case "browse_button":
 case "clear_button":

makes it more readable.
Attachment #215974 - Flags: review?(doronr) → review+
(Assignee)

Comment 6

12 years ago
Created attachment 215980 [details] [diff] [review]
for checkin
Attachment #215974 - Attachment is obsolete: true

Comment 7

12 years ago
Checked into trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch

Updated

12 years ago
Blocks: 332853

Updated

12 years ago
Keywords: fixed1.8.0.3, fixed1.8.1

Updated

12 years ago
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.