328217 - Camino build busted on gcc3.3 using SDK 10.4u

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Håkan Waara]

The bustage is here:

Users/hakan/Documents/Programmering/mozilla/camino/src/bookmarks BookmarkViewController.mm:723: error: cannot convert `NSXMLNode*' to `BookmarkFolder*' in initialization

A proposed fix that builds for me:

Index: src/bookmarks/BookmarkViewController.mm
===================================================================
RCS file: /cvsroot/mozilla/camino/src/bookmarks/BookmarkViewController.mm,v
retrieving revision 1.62
diff -u -r1.62 BookmarkViewController.mm
--- src/bookmarks/BookmarkViewController.mm     30 Jan 2006 04:51:33 -0000      1.62
+++ src/bookmarks/BookmarkViewController.mm     22 Feb 2006 19:40:18 -0000
@@ -720,7 +720,7 @@
   // first arrange the items at the top level
   if ([bmItems count] > 1)
   {
-    BookmarkFolder* itemsParent = [[bmItems firstObject] parent];
+    BookmarkFolder* itemsParent = (BookmarkFolder*) [[bmItems firstObject] parent];
     [itemsParent arrangeChildItems:bmItems usingSelector:sortSelector reverseSort:reverseSort];
   }


Reviews?
   

BTW, in other parts of the tree I note warnings like these, so it seems to be a widespread problem:

/Users/hakan/Documents/Programmering/mozilla/camino/src/bookmarks/BookmarkToolbar.mm: In function `BOOL -[BookmarkToolbar performDragOperation:](BookmarkToolbar*, objc_selector*, objc_object*)':
/Users/hakan/Documents/Programmering/mozilla/camino/src/bookmarks/BookmarkToolbar.mm:681: warning: `NSXMLNode' may not respond to `-copyChild:toBookmarkFolder:atIndex:'
/Users/hakan/Documents/Programmering/mozilla/camino/src/bookmarks/BookmarkToolbar.mm:683: warning: `NSXMLNode' may not respond to `-moveChild:toBookmarkFolder:atIndex:'

Comment 1

[Mike Pinkerton (not reading bugmail)]

sr=pink.

Comment 2

[Håkan Waara]

Checked in on trunk

Comment 3

[Chris Lawson (gone)]

Yeah, we have a ton of missing casts. I think I have most of them fixed in my tree, so they're slowly making it in with my patches. :)

cl