328225 - [regression] ForecastFox 0.8.5.1 extension has started to hang/crash firefox.

Status: VERIFIED INVALID

(Firefox :: General, defect)

Description

[Steve England [:stevee]]

1. New profile.
2. Install ForecastFox 0.8.5.1 from http://releases.mozilla.org/pub/mozilla.org/extensions/forecastfox/forecastfox-0.8.5.1-fx+mz+ns.xpi
3. Restart firefox.
4. Enter '10001' as an area-code to receive weather about.
5. Open some tabs, refresh, browse a little. Try the tinderbox pages

Firefox crashes.

TB15484418X
TB15484406H

Has worked fine upto and including:
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060222 Firefox/1.6a1 ID:2006022202

Hangs/crashes in:
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060222 Firefox/1.6a1 ID:2006022209

Checkin range:
- http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-02-22+01&maxdate=2006-02-22+09&cvsroot=%2Fcvsroot

Comment 1

[:Gavin Sharp [email: [e-mail]]]

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1140598800&maxdate=1140627600

Comment 2

[Steve England [:stevee]]

- To aid crashing, try refreshing the weather forecast (right click on the statusbar weather icons and choose 'Reload Weather Data')

- Enabling/Disabling the SSL2 option for the 2006022209 build makes no difference to forecastfox; it still hangs/crashes firefox.

Comment 3

[Jon Henry]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060222 Firefox/1.6a1

Confirming on Windows XP. Starting with this build which I compiled this morning, the Forecastfox/Firefox combo crashes and/or hangs with great frequency. I seem to crash 100% of the time loading planet.mozilla.org.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

don't use createInstance for the io service. not a mozilla bug.

(that said, bug 328218 will stop the crashing)

$ grep -r nsIIOS .
./components/ffDisk.js:    var ios = Components.classes["@mozilla.org/network/io-service;1"].createInstance(Components.interfaces.nsIIOService);
./components/nsForecastfox.js:    var ios = Components.classes["@mozilla.org/network/io-service;1"].createInstance(Components.interfaces.nsIIOService);
./components/nsForecastfox.js:    var ios = Components.classes["@mozilla.org/network/io-service;1"].getService(Components.interfaces.nsIIOService);
./components/nsForecastfox.js:        var ios = Components.classes["@mozilla.org/network/io-service;1"].getService(Components.interfaces.nsIIOService);
Übereinstimmungen in Binärdatei ./chrome/forecastfox.jar.
./chrome/content/forecastfox/icons.js:    var ios = Components.classes["@mozilla.org/network/io-service;1"].createInstance(Components.interfaces.nsIIOService);
./chrome/content/forecastfox/forecastfox.js:    var ios = Components.classes["@mozilla.org/network/io-service;1"].getService(Components.interfaces.nsIIOService);

Comment 5

[Boris Zbarsky [:bzbarsky]]

Please make sure there's a bug filed on ForecasterFox, ok?

Comment 6

[Steve England [:stevee]]

Did do Boris. Version 0.8.5.2 was released shortly after and fixed the crashing.