328231 - \"window moved to offscreen position" messages are annoying

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Aleks Totic]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1

When debugging Mozilla, I get "window moved to offscreen position" messages a lot. I have multiple monitors, and the code was not taking multiple monitors into account. I've created and tested a patch that works for multiple monitors.

Reproducible: Always

Steps to Reproduce:
Run mozilla under debug with multiple monitors, and start mozilla on the monitor that is not primary.

Comment 1

[Aleks Totic]

Attachment: Adds multiple-monitor support for offscreen warning

Comment 2

[mmc]

Is this still an issue?

Comment 3

[Aleks Totic]

I think the fix was checked in as part of another bug fix.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 212803 [details] [diff] [review]
Adds multiple-monitor support for offscreen warning


(In reply to comment #3)
> I think the fix was checked in as part of another bug fix.

Not in m-c at least.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 212803 [details] [diff] [review]
Adds multiple-monitor support for offscreen warning

Sorry, I'm not a peer of this code.

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 212803 [details] [diff] [review]
Adds multiple-monitor support for offscreen warning

+      if (aX < mi.rcMonitor.left || aX >= mi.rcMonitor.right || aY < mi.rcMonitor.top || aY >= mi.rcMonitor.bottom)

nit - wrap that to ~80 characters or so.

Comment 7

[Jim Mathies [:jimm]]

wow, I wonder if Aleks is still tuned in after four years?