328232 - Images with alpha are broken for X

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

As discussed on IRC, gfxPlatformGtk::CreateOffscreenSurface isn't doing the right thing. Patch forthcoming.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: updated fix

Sorry vlad, that patch wasn't good. We need to get the bpp from the xrender format.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: updated fix

Sorry vlad, that patch wasn't good. We need to get the bpp from the xrender format.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(and we need to unset the gdk colormap, or I get tons of assertion spew)

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 212819 [details] [diff] [review]
updated fix

bleh, every time I think I understand what X is doing, it does something weird.  RENDER and everything else is just a mess.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, it sucks hugely. We might be able to simplify life a little if we get rid of the need for the surface to have an associated GdkDrawable ... then perhaps we can get Gdk out of the loop entirely and only have to wrangle X11 and RENDER.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(and make this gfxPlatformX)

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in