328243 - disband the browser shim

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

...and move all the content into the browser code.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

- Moves stuff into browser.js and the various .xul and .inc files
- Moves locale files into browser/locales directory
- Moves theme files into browser/themes directory

Comment 2

[Annie Sullivan]

Comment on attachment 212960 [details] [diff] [review]
patch


>+++ browser/base/content/browser-doctype.inc	23 Feb 2006 22:41:32 -0000
>@@ -6,10 +6,12 @@
> <!ENTITY % globalDTD SYSTEM "chrome://global/locale/global.dtd">
> %globalDTD;
> <!ENTITY % globalRegionDTD SYSTEM "chrome://global-region/locale/region.dtd">
> %globalRegionDTD;
> <!ENTITY % charsetDTD SYSTEM "chrome://global/locale/charsetOverlay.dtd" >
> %charsetDTD;
> <!ENTITY % findBarDTD SYSTEM "chrome://global/locale/findbar.dtd" >
> %findBarDTD;
>+<!ENTITY % placesDTD SYSTEM "chrome://browser/locale/places/places.dtd">
>+%placesDTD;
> ]>

Shouldn't there be a #ifdef MOZ_PLACES around this?

>Index: browser/themes/pinstripe/browser/places/places.css
>===================================================================
>RCS file: browser/themes/pinstripe/browser/places/places.css
>diff -N browser/themes/pinstripe/browser/places/places.css
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ browser/themes/pinstripe/browser/places/places.css	23 Feb 2006 22:41:33 -0000
>@@ -0,0 +1,276 @@
> ...
>+/* Personal toolbar */
>+.toolbar-drop-indicator {
>+  height: 16px;
>+  width: 5px;
>+  margin-bottom: -8px;
>+  position: relative;
>+  background: url('chrome://browser/skin/places/toolbarDropMarker.png') 50% 50% no-repeat;
>+}
>+
>+.toolbar-drop-indicator-bar {
>+  display: none;
>+  height: 16px;
>+  margin-bottom: -16px;
>+  margin-left: 4px;
>+  position: relative;
>+}
>+
>+.toolbar-drop-indicator-bar[dragging="true"] {
>+  display: -moz-box;
>+}
>+
>+toolbarbutton.bookmark-item[dragover="true"][open="true"] {
>+  -moz-appearance: none;
>+  background: Highlight !important;
>+  color: HighlightText !important;
>+  list-style-image: url('chrome://browser/skin/places/folderDragOver.png') !important;
>+  -moz-image-region: rect(0px, 16px, 16px, 0px) !important;
>+}
>+
>+.bookmark-item[dragover-into="true"] {
>+  background: Highlight !important;
>+  color: HighlightText !important;
>+}
>+
>+.bookmark-item[dragover-top="true"] {
>+  -moz-border-top-colors: #000000;
>+}
>+
>+.bookmark-item[dragover-bottom="true"] {
>+  -moz-border-bottom-colors: #000000;
>+}

These styles were removed from places.css in bug 327762 because they apply to the main browser window, not the places page.  Why are they being added back in?  (Same goes for winstripe places.css)

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch, addresses issues

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 212964 [details] [diff] [review]
patch, addresses issues

nope. one sec.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: ok, this one

Make sure the styles remain in the right place.

Comment 6

[Phil Ringnalda (:philor)]

The hunks for mozilla/browser/themes/winstripe/browser/browser.css and mozilla/browser/themes/pinstripe/browser/browser.css didn't make it into the trunk, only the branch.

Comment 7

[Brett Wilson]

*** Bug 328846 has been marked as a duplicate of this bug. ***

Comment 8

[:Gavin Sharp [email: [e-mail]]]

why did the checkin for this bug comment out a bunch of blocks of code in browser.js?

Comment 9

[u60234]

And why were the "Firefox and Mozilla Links" in bookmarks.html on 1.8 branch replaced with pre-Firefox 1.5 links?

Comment 10

[Phil Ringnalda (:philor)]

Setting back to FIXED, Annie landed the missing hunks quite a while ago, and regression bugs on the landed-but-unsatisfactory parts are more likely to get somewhere.

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv