Cert Viewer: Prefix "raw bytes" display with size information

RESOLVED FIXED

Status

Core Graveyard
Security: UI
--
enhancement
RESOLVED FIXED
12 years ago
a year ago

People

(Reporter: kaie, Assigned: kaie)

Tracking

({fixed1.8.1})

Trunk
fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
As of today, unknown certificate properties are displays as HEX bytes.
It would be helpful to display the size in bytes and bits.

I propose to change the current display of:
  01 02 03 04 05 06 07 08 ....
  ....

to
  Size: 10 Bytes / 80 Bits
  01 02 03 04 05 06 07 08 ....
  ....

For example, this makes it easier to quickly get an idea about key sizes.
(Assignee)

Comment 1

12 years ago
Created attachment 212883 [details] [diff] [review]
Patch v1

Attaching proposed patch.

While the real change is a small chunk of new code, it was necessary to add an nssComponent parameter to function processRawBytes and all callers.
Attachment #212883 - Flags: review?(rrelyea)

Comment 2

12 years ago
Comment on attachment 212883 [details] [diff] [review]
Patch v1

r+=relyea.
Attachment #212883 - Flags: review?(rrelyea) → review+
(Assignee)

Updated

12 years ago
Attachment #212883 - Flags: approval-branch-1.8.1+
(Assignee)

Comment 3

12 years ago
fixed trunk and 1.8 branch
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.