328401 - Mac packaging should fail if the stuff to package is missing

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Mark Mentovai]

Follow-up from bug 328383.  The Mac packager (pkg-dmg) should fail with a nonzero exit status when its source is missing, instead of successfully packaging nothing.

Comment 1

[Mark Mentovai]

There is no bug in pkg-dmg.  (That should please me more than anyone else, especially since one of the major design goals of pkg-dmg was to have complete error checking.)  It relies on rsync to signal an error when the source directory is missing, and properly interprets the error from rsync and croaks:

554 if(command($gConfig{'cmd_rsync'}, '-a', '--copy-unsafe-links',
555  $sourceFolder.($sourceFile?'':'/'),$tempRoot) != 0) {
556   cleanupDie('rsync failed');
557 }

This was causing a problem in bug 328383.  The tinderbox build log looked like this:

Creating package directory...
Stripping package directory...
/bin/sh: line 1: cd: ../../dist/universal/thunderbird: No such file or directory
signing nss libraries
/bin/sh: line 1: ../../dist/../../ppc/dist/bin/run-mozilla.sh: No such file or directory
Removing unpackaged files...
cd ../../dist/universal/thunderbird/Thunderbird.app/Contents/MacOS; rm -rf TestGtkEmbed bloaturls.txt codesighs* elf-dynstr-gc thunderbird-bin.elf thunderbird-config mangle* maptsv* mfc* mkdepend* msdump* msmap* nm2tsv* nsinstall* regxpcom* res/samples res/throbber shlibsign* winEmbed.exe xpcshell* xpidl* xpt_dump* xpt_link* dirver* plugins res/arrow.gif res/arrowd.gif res/boatcycle.html res/cmessage.txt res/html res/loading-image.gif res/rdf res/viewer.properties res/viewsource.css chrome/chromelist.txt chrome/embed-sample.jar PalmSyncInstall.exe components/libgkplugin.so components/plugin.xpt components/gkplugin.dll  core bsdecho gtscc jscpucfg nsinstall viewer TestGtkEmbed bloaturls.txt codesighs* elf-dynstr-gc mangle* maptsv* mfc* mkdepend* msdump* msmap* nm2tsv* nsinstall* rebasedlls* res/samples res/throbber shlibsign* winEmbed.exe os2Embed.exe chrome/chrome.rdf chrome/app-chrome.manifest chrome/overlayinfo components/compreg.dat components/xpti.dat 
/bin/sh: line 1: cd: ../../dist/universal/thunderbird/Thunderbird.app/Contents/MacOS: No such file or directory
/builds/tinderbox/Tb-Mozilla1.8.0/Darwin_7.9.0_Depend/mozilla/config/nsinstall -t removed-files ../../dist/universal/thunderbird/Thunderbird.app/Contents/MacOS
Compressing...
cd ../../dist; /builds/tinderbox/Tb-Mozilla1.8.0/Darwin_7.9.0_Depend/mozilla/build/package/mac_osx/pkg-dmg --source "universal/thunderbird" --target "thunderbird-1.5.0.2.en-US.mac.dmg" --volname "Thunderbird"  --copy "branding/dsstore:/.DS_Store" --mkdir /.background --copy "branding/background.png:/.background" --icon "branding/disk.icns" --resource "branding/license.r"

pkg-dmg then did NOT fail.

Based on the transcript above, the universal/thunderbird directory on which pkg-dmg's success depended was created by nsinstall.  pkg-dmg was packaging a Thunderbird.app devoid of all appropriate contents except for the removed-files file.  Downloading the dmg that was released from this horked build confirms.