configure and Makefile include .svn directories if run from inside a subversion repository

RESOLVED FIXED

Status

Webtools Graveyard
Tinderbox2
RESOLVED FIXED
13 years ago
4 years ago

People

(Reporter: bear, Assigned: bear)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

13 years ago
This bug is courtesy of John L. Villalovos and was sent to me via email.

His two patches allow the configure and Makefile script to handle excluding .svn directories if they are run from a Tinderbox2 subversion working directory.

I modified his patches in a minor fashion.
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

13 years ago
Created attachment 212994 [details] [diff] [review]
patch to exclude .svn files in configure and Makefile when they look for perl code
Attachment #212994 - Flags: review?

Updated

13 years ago
Blocks: 329639

Updated

13 years ago
No longer blocks: 329639

Updated

12 years ago
Attachment #212994 - Flags: review? → review?(benjamin)

Comment 2

12 years ago
Comment on attachment 212994 [details] [diff] [review]
patch to exclude .svn files in configure and Makefile when they look for perl code

I don't own (or know anything about) tinderbox2. Bumping to timeless.
Attachment #212994 - Flags: review?(benjamin) → review?(timeless)

Comment 3

12 years ago
Comment on attachment 212994 [details] [diff] [review]
patch to exclude .svn files in configure and Makefile when they look for perl code

for the record, i seem to recall actively complaining about this code. i wanted something that whitelisted stuff that made sense instead of blacklisting things that didn't make sense.

that said, if this is really only supposed to be about the second patched file, then i'd probably review+ just that patch.
Attachment #212994 - Flags: review?(timeless) → review-
(Assignee)

Comment 4

12 years ago
Created attachment 222315 [details] [diff] [review]
patch to exclude .svn directories in configure

removed the Makefile bits from the patch as they don't apply to this bug
Attachment #212994 - Attachment is obsolete: true
Attachment #222315 - Flags: review?(timeless)

Updated

12 years ago
Attachment #222315 - Flags: review?(timeless) → review+
(Assignee)

Comment 5

12 years ago
patch applied in revision 1.25
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
QA Contact: kestes → tinderbox2
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.