Many of the files in svg/content are concrete implementations of SVG elements and as such are classes defined with class definition and implementation in a single file. They are not intended to be inherited from. E.g. nsSVGCircleElement.cpp They often have empty/stub destructors implemented which is a waste, these should be removed. See bug 325728 comment 13 and bug 325728 comment 15
Comment on attachment 223370 [details] [diff] [review] Removed Destructors It's nice to have consistancy regarding the number of blank lines left. Can you at least reduce the number of blank lines left where nsSVGPolygoneElement::~nsSVGPolygoneElement was to two and not three? r=jwatt
Attachment #223370 - Flags: review?(jwatt) → review+
Attachment #223374 - Flags: superreview? → superreview?(tor)
Checked in for Alex.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.