Remove empty destructors from svg/content

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: longsonr, Assigned: malex)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

13 years ago
Many of the files in svg/content are concrete implementations of SVG elements and as such are classes defined with class definition and implementation in a single file. They are not intended to be inherited from. E.g. nsSVGCircleElement.cpp

They often have empty/stub destructors implemented which is a waste, these should be removed.

See bug 325728 comment 13 and  bug 325728 comment 15
Assignee

Comment 1

13 years ago
Posted patch Removed Destructors (obsolete) — Splinter Review
Assignee

Updated

13 years ago
Attachment #223370 - Flags: superreview?(tor)
Attachment #223370 - Flags: review?(jwatt)
Comment on attachment 223370 [details] [diff] [review]
Removed Destructors

It's nice to have consistancy regarding the number of blank lines left. Can you at least reduce the number of blank lines left where nsSVGPolygoneElement::~nsSVGPolygoneElement was to two and not three? r=jwatt
Attachment #223370 - Flags: review?(jwatt) → review+
Assignee

Comment 3

13 years ago
Attachment #223374 - Flags: superreview?
Attachment #223374 - Flags: review?(jwatt)
Assignee

Updated

13 years ago
Attachment #223374 - Flags: superreview? → superreview?(tor)
Attachment #223374 - Flags: review?(jwatt) → review+
Assignee: general → amenzie
Assignee

Updated

13 years ago
Attachment #223370 - Attachment is obsolete: true
Attachment #223370 - Flags: superreview?(tor)

Updated

13 years ago
Attachment #223374 - Flags: superreview?(tor) → superreview+

Comment 4

13 years ago
Checked in for Alex.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.