Closed
Bug 328433
Opened 18 years ago
Closed 18 years ago
Remove empty destructors from svg/content
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: longsonr, Assigned: malex)
Details
Attachments
(1 file, 1 obsolete file)
|
19.54 KB,
patch
|
jwatt
:
review+
tor
:
superreview+
|
Details | Diff | Splinter Review |
Many of the files in svg/content are concrete implementations of SVG elements and as such are classes defined with class definition and implementation in a single file. They are not intended to be inherited from. E.g. nsSVGCircleElement.cpp They often have empty/stub destructors implemented which is a waste, these should be removed. See bug 325728 comment 13 and bug 325728 comment 15
|
Assignee | |
Comment 1•18 years ago
|
||
|
|
Assignee | |
Updated•18 years ago
|
Attachment #223370 -
Flags: superreview?(tor)
Attachment #223370 -
Flags: review?(jwatt)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 223370 [details] [diff] [review] Removed Destructors It's nice to have consistancy regarding the number of blank lines left. Can you at least reduce the number of blank lines left where nsSVGPolygoneElement::~nsSVGPolygoneElement was to two and not three? r=jwatt
Attachment #223370 -
Flags: review?(jwatt) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Attachment #223374 -
Flags: superreview?
Attachment #223374 -
Flags: review?(jwatt)
|
|
Assignee | |
Updated•18 years ago
|
Attachment #223374 -
Flags: superreview? → superreview?(tor)
|
|
||
Updated•18 years ago
|
Attachment #223374 -
Flags: review?(jwatt) → review+
|
|
||
Updated•18 years ago
|
Assignee: general → amenzie
|
|
Assignee | |
Updated•18 years ago
|
Attachment #223370 -
Attachment is obsolete: true
Attachment #223370 -
Flags: superreview?(tor)
Attachment #223374 -
Flags: superreview?(tor) → superreview+
Checked in for Alex.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•