328479 - Building the jsshell on VC++ 6 fails because jsautokw.h is missing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[someone]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1

I'm trying to build the jsshell with VC++ 6, but it fails because the file jsautokw.h is missing.

Reproducible: Always

Steps to Reproduce:
1. Checking out the sources with WinCVS 2.0.2.4, using the cvsroot ":pserver:[e-mail]:/cvsroot" and the module name "mozilla/js/src".
2. running "nmake /f js.mak CFG="jsshell - Win32 Release" clean all" in the src folder.

Actual Results:  
The build fails because it cannot find the jsautokw.h file:

jsscan.c
jsscan.c(114) : fatal error C1083: Cannot open include file: 'jsautokw.h': No su
ch file or directory
NMAKE : fatal error U1077: 'cl.exe' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Programme\Microsoft Visual Studio\VC98\bin\NMAKE
.EXE"' : return code '0x2'
Stop.

Expected Results:  
It should have build jsshell.exe and js32.dll.

Comment 1

[Frederic Bezies]

Smell like you're not using the right way to build firefox.

Nmake is no more used since year 2000 or so.

So, read this http://developer.mozilla.org/en/docs/Windows_Build_Prerequisites and this http://developer.mozilla.org/en/docs/Build_Documentation

And you will build it without problem.

-> INVALID ?

Comment 2

[someone]

(In reply to comment #1)
> Smell like you're not using the right way to build firefox.
> 
> Nmake is no more used since year 2000 or so.
> 
> So, read this http://developer.mozilla.org/en/docs/Windows_Build_Prerequisites
> and this http://developer.mozilla.org/en/docs/Build_Documentation
> 
> And you will build it without problem.

I'm not trying to build firefox, Im trying to build the standalone jsshell, especially the js32.dll. And according to the included readme it should even work with MSVC5.

Comment 3

[Gerry Sweeney]

Attachment: A ZIP file with VC6 Project files that builds the SpiderMonkey engine

This is a collection of VC6 project files that correctly build the SpiderMonkey engine

Comment 4

[someone]

(In reply to comment #3)
> Created an attachment (id=213094) [edit]
> A ZIP file with VC6 Project files that builds the SpiderMonkey engine
> 
> This is a collection of VC6 project files that correctly build the SpiderMonkey
> engine

The included readme is empty, but after figuring out where to place the project files it did build. But it does not work right! While linking I'm getting the following message:

   Creating library .\lib\js32.lib and object .\lib\js32.exp
LINK : warning LNK4098: defaultlib "LIBC" conflicts with use of other libs; use /NODEFAULTLIB:library

And the application that's using the JS engine crashes upon trying to load and intialize it.

Comment 5

[Gerry Sweeney]

Attachment: A ZIP file with VC6 Project files that builds the SpiderMonkey engine - Fixed

This is an update to my previous post. The linker was reporting a warning when building the non-threading versions of the shared libraries.

Comment 6

[Bob Clary [:bc] (inactive)]

working on it this weekend.

Comment 7

[Gerry Sweeney]

Attachment: A ZIP file with VC6 Project files that builds the SpiderMonkey engine - Fixed

I have added the linker option /OPT:NOICF as highlighted in a recent post to the news group.

Comment 8

[timeless]

Attachment: working patch

Comment 9

[timeless]

Comment on attachment 217140 [details] [diff] [review]
working patch

mozilla/js/src/js.mak 	3.10

i'd claim this is fixed, but i wrote this patch using vc7.0 and don't feel like testing it w/ vc6.0 at 6am.

the project files while interesting aren't actually the subject of this bug. and i don't really feel like maintaining yet another file format. that we actually try to support nmake and gmake clearly causes enough headaches. supporting the project formats for vc4..8 seems to be asking for way too much pain (yes we have one binary project file in cvs for this stuff, but it's clearly not going anywhere).

Comment 10

[Bob Clary [:bc] (inactive)]

all targets build for me in vc6 with js.mak 3.11. debug clean leaves vc60.idb and vc60.pdb in the Debug dir though similar to the situation in bug 332689.