328496 - search engines appear multiple times

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060224 Firefox/1.6a1 ID:2006022400-Cairo

repro:
1. Open Firefox
2. press on default searchengine to to select different one

result:
every engine is multiple times in the list

Comment 1

[Peter van der Woude [:Peter6]]

regressionwindow:
works in 20060223 1035pst build
fails in 20060223 1523pst build

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=20060223+1000&maxdate=20060223+1523&cvsroot=%2Fcvsroot

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

*** Bug 328495 has been marked as a duplicate of this bug. ***

Comment 3

[Peter van der Woude [:Peter6]]

happens in both cairo and non-cairo builds

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Most likely a regression from bug 328496.

Comment 5

[Martijn Wargers (dead)]

More likely to be a regression from bug 326712 ;)

Comment 6

[:Gavin Sharp [email: [e-mail]]]

oh, right :)
stupid clipboard.

Comment 7

[Neil Deakin]

Attachment: remove old content when replacing matches

Turns out that the search service is modifying the RDF while the template is initially being built. This causes the modification notifications to update the template, then the initial build continues adding the same data again. Fix this by removing the old content when replacing a match similar to bug 327504.

Why is the search service adding all the engines, removing them all again, and then readding them? For sorting?