Support mozilla/layout on WinXP x64 build

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
13 years ago
8 months ago

People

(Reporter: m_kato, Unassigned)

Tracking

Trunk
x86
Windows Server 2003
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.2; WOW64; SV1; .NET CLR 2.0.50727)
Build Identifier: 

mozilla/layout/generic/nsObjectFrame.cpp isn't 64-bit safe.

Reproducible: Always

Steps to Reproduce:
To fix, I chage PRUint32 to PRUword.  PRWord is generic pointer type suc as "void*".
Component: Layout → Layout: Misc Code
+      if (NS_REINTERPRET_CAST(PRUword, window->window) != (PRUword)(HDC)hdc) {

wouldn't a better fix be to cast the left side to HDC instead and not to cast the right side?
(In reply to comment #3)
> +      if (NS_REINTERPRET_CAST(PRUword, window->window) != (PRUword)(HDC)hdc) {
> 
> wouldn't a better fix be to cast the left side to HDC instead and not to cast
> the right side?
> 

HDC is equal to void* or HANDLE, not PRUint32.  Microsoft Win64 compiler uses LLP64 model.
I don't understand, I meant this:
      if (NS_REINTERPRET_CAST(HDC, window->window) != hdc) {

Why wouldn't that work?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #230577 - Flags: review?(cbiesinger) → review+
Makoto, were you planning on getting this checked in at some point? :-)
(In reply to comment #8)
> Makoto, were you planning on getting this checked in at some point? :-)

I forgot checking in.  So I will send review/super-review with latest diff again. 
Attachment #267966 - Flags: review?(cbiesinger) → review+
Comment on attachment 267966 [details] [diff] [review]
a patch for latest mozilla/layout

sr=dbaron
Attachment #267966 - Flags: superreview?(dbaron) → superreview+
checked in
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

8 months ago
Product: Core → Core Graveyard
(Assignee)

Updated

8 months ago
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.