328547 - Support mozilla/layout on WinXP x64 build

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Makoto Kato [:m_kato]]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.2; WOW64; SV1; .NET CLR 2.0.50727)
Build Identifier: 

mozilla/layout/generic/nsObjectFrame.cpp isn't 64-bit safe.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Makoto Kato [:m_kato]]

Attachment: a patch for mozilla/layout

Comment 2

[Makoto Kato [:m_kato]]

To fix, I chage PRUint32 to PRUword.  PRWord is generic pointer type suc as "void*".

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

+      if (NS_REINTERPRET_CAST(PRUword, window->window) != (PRUword)(HDC)hdc) {

wouldn't a better fix be to cast the left side to HDC instead and not to cast the right side?

Comment 4

[Makoto Kato [:m_kato]]

(In reply to comment #3)
> +      if (NS_REINTERPRET_CAST(PRUword, window->window) != (PRUword)(HDC)hdc) {
> 
> wouldn't a better fix be to cast the left side to HDC instead and not to cast
> the right side?
> 

HDC is equal to void* or HANDLE, not PRUint32.  Microsoft Win64 compiler uses LLP64 model.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

I don't understand, I meant this:
      if (NS_REINTERPRET_CAST(HDC, window->window) != hdc) {

Why wouldn't that work?

Comment 6

[Makoto Kato [:m_kato]]

Your fix is better.

Comment 7

[Makoto Kato [:m_kato]]

Attachment: a patch for mozilla/layout

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Makoto, were you planning on getting this checked in at some point? :-)

Comment 9

[Makoto Kato [:m_kato]]

Attachment: a patch for latest mozilla/layout

Comment 10

[Makoto Kato [:m_kato]]

(In reply to comment #8)
> Makoto, were you planning on getting this checked in at some point? :-)

I forgot checking in.  So I will send review/super-review with latest diff again. 

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 267966 [details] [diff] [review]
a patch for latest mozilla/layout

sr=dbaron

Comment 12

[Makoto Kato [:m_kato]]

checked in