percentage width and height should work inside of svg:foreignObject

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

12 years ago
Percentage widths and heights should work inside of svg:foreignObject, since it does have fixed width and height.  Patch and testcase coming.
(Assignee)

Comment 1

12 years ago
Created attachment 213156 [details]
testcase (not simplified)
(Assignee)

Comment 2

12 years ago
Created attachment 213157 [details] [diff] [review]
patch

This pulls forward some things that I'd done on the reflow branch and does them a good bit better than what I have there.  There are still bugs as described by the "XXXldb" comment, but that's probably better fixed in a separate patch (probably that reflows foreignObject descendants at Reflow time).
Attachment #213157 - Flags: superreview?(roc)
Attachment #213157 - Flags: review?(roc)
(Assignee)

Updated

12 years ago
Whiteboard: [patch]
Can't you use nsAutoSpaceManager here?
(Assignee)

Comment 4

12 years ago
I started to use nsAutoSpaceManager, but realized there wasn't much point, since we always create a space manager, and most of the work it does is to deal with the case of sometimes creating a space manager.
(Assignee)

Comment 5

12 years ago
Created attachment 213304 [details]
testcase (not simplified)
Attachment #213156 - Attachment is obsolete: true
Comment on attachment 213157 [details] [diff] [review]
patch

ah right. Thanks
Attachment #213157 - Flags: superreview?(roc)
Attachment #213157 - Flags: superreview+
Attachment #213157 - Flags: review?(roc)
Attachment #213157 - Flags: review+
(Assignee)

Comment 7

12 years ago
Checked in to trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

12 years ago
Filed bug 328829 as the followup issue on style changes requiring reflow.
You need to log in before you can comment on or make changes to this bug.