percentage width and height should work inside of svg:foreignObject

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(2 attachments, 1 obsolete attachment)

Percentage widths and heights should work inside of svg:foreignObject, since it does have fixed width and height.  Patch and testcase coming.
Posted patch patchSplinter Review
This pulls forward some things that I'd done on the reflow branch and does them a good bit better than what I have there.  There are still bugs as described by the "XXXldb" comment, but that's probably better fixed in a separate patch (probably that reflows foreignObject descendants at Reflow time).
Attachment #213157 - Flags: superreview?(roc)
Attachment #213157 - Flags: review?(roc)
Whiteboard: [patch]
Can't you use nsAutoSpaceManager here?
I started to use nsAutoSpaceManager, but realized there wasn't much point, since we always create a space manager, and most of the work it does is to deal with the case of sometimes creating a space manager.
Comment on attachment 213157 [details] [diff] [review]
patch

ah right. Thanks
Attachment #213157 - Flags: superreview?(roc)
Attachment #213157 - Flags: superreview+
Attachment #213157 - Flags: review?(roc)
Attachment #213157 - Flags: review+
Checked in to trunk.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Filed bug 328829 as the followup issue on style changes requiring reflow.
You need to log in before you can comment on or make changes to this bug.