328550 - percentage width and height should work inside of svg:foreignObject

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Percentage widths and heights should work inside of svg:foreignObject, since it does have fixed width and height.  Patch and testcase coming.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase (not simplified)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This pulls forward some things that I'd done on the reflow branch and does them a good bit better than what I have there.  There are still bugs as described by the "XXXldb" comment, but that's probably better fixed in a separate patch (probably that reflows foreignObject descendants at Reflow time).

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Can't you use nsAutoSpaceManager here?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I started to use nsAutoSpaceManager, but realized there wasn't much point, since we always create a space manager, and most of the work it does is to deal with the case of sometimes creating a space manager.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase (not simplified)

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 213157 [details] [diff] [review]
patch

ah right. Thanks

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Filed bug 328829 as the followup issue on style changes requiring reflow.