328586 - "Save Image" should be "Save Image As..." and "Save Link Location" "Save Link As..." link in firefox

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[xolaware.llc]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: 20060225 Thunderbird/1.6a1

for many moons, "Save Image As..." existed as a context menu-item when ctrl-clicking on an image in a message.

it is now gone.

please put it back, even if it means there will be both "Save Image" and "Save Image As..."

Reproducible: Always

Steps to Reproduce:
1. open a message with an image in it (inline, attach, or URL)
2. ctrl-click to get context-menu

Actual Results:  
"Save Image" is in menu

Expected Results:  
"Save Image" and "Save Image As..." should both be in menu

it would appear that Save Image also does nothing, but there's already a bugzilla report for that.

Comment 1

[Mike Cowperthwaite]

Under Windows, at least, TB 1.5 only has "Save Image" -- but it *does* do something there.  In fact, it *acts* as "Save Image As...".

(In reply to comment #0)
> it would appear that Save Image also does nothing, but there's already a
> bugzilla report for that.

I searched and I couldn't find one that existed when this bug was opened, but bug 334544 is about this problem.

Comment 2

[Mike Cowperthwaite]

OK, I found the earlier report: bug 306972.

Comment 3

[Frankie]

TB 1.5, OSX 10.4.latest.
If inline image: CM has "Save Image" which displays a file dialog (aka Save As...)
If link to file: CM has "Save Link Target" which displays a file dialog.

Dunno about 1.6/2.0/whatever.

Comment 4

[xolaware.llc]

just curious before filing a separate bug report ...

as of all nightly builds after [TB version 3 alpha 1 (20060524)], images (whether linked or not) are not being displayed in messages, and the context menu items for each are failing.

i'd still like to see "Save Image As..." return, because i don't like to have to just have the images go to a particular place based on where "Save Image" saves them.  the dialog that comes up to save them is very useful.

Comment 5

[Adam Guthrie]

Scott checked this in on 2006-02-14 15:56 as part of the fix for bug 251296. I'm not sure why he did this, other than that fact to match how SeaMonkey does this. (It's been like this since the dark ages there.)

Comment 6

[Magnus Melin [:mkmelin] (away, back Aug 4)]

Attachment: proposed fix

Fix the context menus to be like the firefox ones.
"Save Link As..." and "Save Image As..."

Comment 7

[Phil Ringnalda (:philor)]

Nice. According to my half-hearted archaeology, we had Save Foo As..., then SM decided to have Save Foo when prefs said to always save to a single dir, and thanks to bad packaging and/or bad forking, that gave us a missing entity, so we got the unused entity instead of better packaging/forking, and then at some point we switched to using the unused and inaccurate one, and got rid of the one we meant to be using. How can you not love that?

Could we maybe use a more semantic SaveFooAsCmd, instead of SaveFooCmd2?

Comment 8

[Magnus Melin [:mkmelin] (away, back Aug 4)]

Attachment: proposed fix, v2

Sure!

Comment 9

[Phil Ringnalda (:philor)]

Comment on attachment 336233 [details] [diff] [review]
proposed fix, v2

Pretty, thanks.

Comment 10

[Phil Ringnalda (:philor)]

Really, r+. Don't make me say it again.

Comment 11

[Magnus Melin [:mkmelin] (away, back Aug 4)]

changeset:   306:104a5f6e939e
http://hg.mozilla.org/comm-central/rev/104a5f6e939e

->FIXED