Last Comment Bug 328592 - TARGET_XPCOM_API undefined for OS X PPC
: TARGET_XPCOM_API undefined for OS X PPC
Status: RESOLVED FIXED
[nvn-dl]
: fixed1.8.0.2, fixed1.8.1, regression
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: PowerPC Mac OS X
: -- blocker (vote)
: ---
Assigned To: Mark Mentovai
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-25 13:17 PST by Mark Mentovai
Modified: 2006-03-02 13:59 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix (610 bytes, patch)
2006-02-25 13:19 PST, Mark Mentovai
benjamin: review+
benjamin: approval‑branch‑1.8.1+
benjamin: approval1.8.0.2+
Details | Diff | Splinter Review

Description Mark Mentovai 2006-02-25 13:17:26 PST
Bug 322578 changed the value of OS_TEST in configure from powerpc to ppc on Mac OS X.  This value is not recognized when setting CPU_ARCH, causing TARGET_XPCOM_ABI and TARGET_OS_ABI to be undefined.  This must block.
Comment 1 Mark Mentovai 2006-02-25 13:19:40 PST
Created attachment 213191 [details] [diff] [review]
Fix
Comment 2 Mark Mentovai 2006-02-25 13:20:55 PST
(Leaving powerpc* in place to account for non-Darwin builds that still use that value.)
Comment 3 Mark Mentovai 2006-02-25 15:08:09 PST
Checked in on trunk, 1.8, and 1.8.0 branches.

Regenerated configure on 1.8.0 branch.

Note You need to log in before you can comment on or make changes to this bug.