328593 - progess/status doesn't work in folder views

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[David :Bienvenu]

If you're in a non-default view, msg progress doesn't happen, because the msgWindow isn't set. Proposed fix coming up.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

this also fixes a few js warnings about the view datasources vars being used without being declared

Comment 2

[David :Bienvenu]

Scott, this also fixes the problem I was seeing where compacting folders wasn't showing progress.

Comment 3

[Scott MacGregor]

Comment on attachment 213193 [details] [diff] [review]
proposed fix

nice find david.

Comment 4

[Mike Cowperthwaite]

(In reply to comment #2)
> this also fixes the problem I was seeing where compacting folders wasn't
> showing progress.

Bug 275199?  Bug 324085?  Bug 325796?

Comment 5

[David :Bienvenu]

this fix only affects folder views (where you cycle through the list of folder views by clicking on the folder name column). It didn't look to me like those users were using folder views. *However*, the cause could be very similar, especially the user who was seeing the problem after closing the stand-alone msg window. From my recollection of the code, that clears the msg window for the datasource, which isn't right...

Comment 6

[David :Bienvenu]

cycling through the views also breaks this. Not sure who's clearing the msgWindow, or if it's using a different datasource. I don't hit a breakpoint on clearing the msgwindow.

Comment 7

[David :Bienvenu]

ah, it's nsMsgRDFDataSource::Cleanup() - I think when we display a folder view, we should re-init the msg window for the datasource(s) involved.

Comment 8

[David :Bienvenu]

Attachment: fix cycling views case

this should fix this bug more generally, though I think we still have a problem if you open a stand-alone msg window and close it (we've always had that problem, I believe)

Comment 9

[Scott MacGregor]

Comment on attachment 213796 [details] [diff] [review]
fix cycling views case

this seems like a reasonable thing to do.

Comment 10

[David :Bienvenu]

last fix checked into trunk and branch.