328742 - MAR files (update.manifest) cannot be reliably recreated exactly

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Mike Kaply [:mkaply]]

I'm investigating creating my own versions of MAR files and I found a 15 byte difference in my update.manifest file.

The difference was that the order of files used in the release manifest seemed completely random (although it was 15 bytes smaller than mine)

I don't think this random order was done deliberately to save 15 bytes - I believe it was file system dependent.

In order to ensure that the MAR files can be recreated reliably, we should sort the results:

find . -type f ! -name "channel-prefs.js" ! -name "update.manifest" | sed 's/\.\/\(.*\)/"\1"/' | sort

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Update.manifest file from 1.5 - 1.5.0.1 build (official)

Comment 2

[Mike Kaply [:mkaply]]

Attachment: update.manifest from my build

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Fix as described

Comment 4

[Mike Kaply [:mkaply]]

Fix checked in.