328760 - Accessibilty code should (probably) be adjusted for bug 299065

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Uri Bernstein]

There are currently four calls to nsFrame::GetNextInFlow() in /accessibility code.
Following the fix for bug 299065, all of these should *probably* be changed to GetNextContinuation(). However, I don't know that code at all, and I'm not sure even where to start looking for testcases.

Aaron, can you please go over these places and confirm that they need to be switched? If you give your approval, I can do the actual creating the patch, getting r/sr, and checking in.

Comment 1

[Ginn Chen]

I think it's OK to switch them.

I didn't test it yet, since they're mainly used by msaa.

Comment 2

[Aaron Leventhal]

> Aaron, can you please go over these places and confirm that they need to be
> switched? If you give your approval, I can do the actual creating the patch,
> getting r/sr, and checking in.

Uri, I didn't see any real comments as to what the difference is or what these do in nsIFrame.h. Could you add some comments to those files, and perhaps dump the info in here? What is the difference between GetNextContinuation() and GetNextInFlow().

Comment 3

[Uri Bernstein]

The comments are in nsSplittableFrame.h: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsSplittableFrame.h&rev=3.31&mark=60-66#60

There's a bit more info in http://wiki.mozilla.org/Gecko:Continuation_Model.

Short srory: GetNext[Prev]InFlow only returns continuations created as a result of line (column, page) breaks, whereas GetNext[Prev]Continuation also returns continuations created by bidi frame splitting (between text runs in opposite directions).

Comment 4

[Aaron Leventhal]

Uri, I don't see a problem with taking that change for all of mozilla/accessible, for trunk.

Comment 5

[Uri Bernstein]

OK, I'll make a patch and post it here (probably early next week, as I'm away from my development machine for the weekend).

Comment 6

[Uri Bernstein]

Attachment: patch

Comment 7

[Uri Bernstein]

Checked in:
Checking in accessible/src/base/nsAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v  <--  nsAccessible.cpp
new revision: 1.181; previous revision: 1.180
done
Checking in accessible/src/base/nsBaseWidgetAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsBaseWidgetAccessible.cpp,v  <--  nsBaseWidgetAccessible.cpp
new revision: 1.44; previous revision: 1.43
done
Checking in accessible/src/msaa/nsTextAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsTextAccessibleWrap.cpp,v  <--  nsTextAccessibleWrap.cpp
new revision: 1.21; previous revision: 1.20
done