328780 - Deprecate SeaMonkeyAll CVS module

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

The SeaMonkeyAll CVS module has needed to die for a long time. Now it can, by using explicitly-named directories in client.mk.

Comment 1

[Benjamin Smedberg]

Attachment: Specify directories explicitly, rev. 1

Comment 2

[timeless]

Comment on attachment 213375 [details] [diff] [review]
Specify directories explicitly, rev. 1

the changes for js mean we instantly get a whole bunch of js we really don't want. i don't want that stuff pulled, i don't want it turning up in searches, i don't want it confusing things. and i'd rather we have explicit
spidermonkey, xpconnect, liveconnect, and jsd modules.

the rest of the changes look fine. that said, if you really don't want to do that work, i suppose it could theoretically be done later.

noting that the changes are technically ok, but not correct, i'm marking since i've given my review. i'd rather you fixed my objections before committing but....

Comment 3

[Darin Fisher]

I assume the CVS modules/partitions will still exist from the point of view of Bonsai and CVS permissions, right?

Comment 4

[Benjamin Smedberg]

The SeaMonkeyAll module will (must) remain in its current form to support historic checkouts. You can continue to use it in bonsai queries if you want, though I suggest MozillaTinderboxAll as a better alternative. AFAIK it is not used in despot.

Comment 5

[Benjamin Smedberg]

timeless, since SeaMonkeyAll already contains all of js/src I'm going to check this in as-is.

Comment 6

[Benjamin Smedberg]

But I didn't, because I was misreading the !dir lines in the modules file. I've fixed that up with a set of "nosubdir" directories and also fixed a bug where if you checkout ldap and then mozilla/configure.in CVS got confused becuase of sticky tags (also fixed by by the nosubdirs checkout rules).

Alternate version FIXED on trunk. No need to take this on branches.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This broke Firefox clobber builds since it stopped pulling themes.  I filed bug 328963 on the need for a Firefox clobbe tinderbox.

Comment 8

[Benjamin Smedberg]

themes/ readded to Firefox checkout until I can fix package-fixup.

Comment 9

[Nickolay_Ponomarev]

Could this be the reason I started getting connection timeouts when trying to update via make -f client.mk checkout MOZ_CO_PROJECT=all? The timeout happens when the cvs co $(GIGANTIC_MODULE_LIST) is executed. Updating the modules in smaller groups works fine.

This is WinXP, cygwin cvs 1.11.6.