Deprecate SeaMonkeyAll CVS module

RESOLVED FIXED in mozilla1.9alpha1

Status

Firefox Build System
General
RESOLVED FIXED
13 years ago
5 months ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

Trunk
mozilla1.9alpha1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
The SeaMonkeyAll CVS module has needed to die for a long time. Now it can, by using explicitly-named directories in client.mk.
(Assignee)

Comment 1

13 years ago
Created attachment 213375 [details] [diff] [review]
Specify directories explicitly, rev. 1
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Attachment #213375 - Flags: review?
(Assignee)

Updated

13 years ago
Attachment #213375 - Flags: review? → review?(timeless)

Comment 2

13 years ago
Comment on attachment 213375 [details] [diff] [review]
Specify directories explicitly, rev. 1

the changes for js mean we instantly get a whole bunch of js we really don't want. i don't want that stuff pulled, i don't want it turning up in searches, i don't want it confusing things. and i'd rather we have explicit
spidermonkey, xpconnect, liveconnect, and jsd modules.

the rest of the changes look fine. that said, if you really don't want to do that work, i suppose it could theoretically be done later.

noting that the changes are technically ok, but not correct, i'm marking since i've given my review. i'd rather you fixed my objections before committing but....
Attachment #213375 - Flags: review?(timeless) → review+

Comment 3

13 years ago
I assume the CVS modules/partitions will still exist from the point of view of Bonsai and CVS permissions, right?
(Assignee)

Comment 4

13 years ago
The SeaMonkeyAll module will (must) remain in its current form to support historic checkouts. You can continue to use it in bonsai queries if you want, though I suggest MozillaTinderboxAll as a better alternative. AFAIK it is not used in despot.
(Assignee)

Comment 5

13 years ago
timeless, since SeaMonkeyAll already contains all of js/src I'm going to check this in as-is.
(Assignee)

Comment 6

13 years ago
But I didn't, because I was misreading the !dir lines in the modules file. I've fixed that up with a set of "nosubdir" directories and also fixed a bug where if you checkout ldap and then mozilla/configure.in CVS got confused becuase of sticky tags (also fixed by by the nosubdirs checkout rules).

Alternate version FIXED on trunk. No need to take this on branches.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
This broke Firefox clobber builds since it stopped pulling themes.  I filed bug 328963 on the need for a Firefox clobbe tinderbox.
(Assignee)

Comment 8

13 years ago
themes/ readded to Firefox checkout until I can fix package-fixup.

Comment 9

13 years ago
Could this be the reason I started getting connection timeouts when trying to update via make -f client.mk checkout MOZ_CO_PROJECT=all? The timeout happens when the cvs co $(GIGANTIC_MODULE_LIST) is executed. Updating the modules in smaller groups works fine.

This is WinXP, cygwin cvs 1.11.6.

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.