328792 - linux thebes requires RENDER extension

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I wasn't thinking about this when we were going through bug 328232 -- the change at http://lxr.mozilla.org/seamonkey/source/gfx/thebes/src/gfxPlatformGtk.cpp#108 means that RENDER is *required* to be present, or we'll get a crash; on servers where RENDER is absent (Xvnc, notably), xrenderFormat is NULL.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix gtk pixmap creation

Fix PlatformGtk pixmap creation; use the best visual we can get for ImageFormatRGB24 (the common case), fall back to image surfaces for the rest.

Also fixes bug with render surface creation -- we were creating a gdk pixmap, but not using it, since it was never passed into the gfxXlibSurface constructor!

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 215803 [details] [diff] [review]
fix gtk pixmap creation


>+        } else {
>+            GdkPixmap* pixmap = gdk_pixmap_new(nsnull, width, height,
>+                                                 xrenderFormat->depth);

Pretend that this doesn't re-delcare pixmap and shadow the previous declaration.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked in, here's hoping for Tp drop!