Closed Bug 328792 Opened 17 years ago Closed 17 years ago

linux thebes requires RENDER extension

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: vlad, Assigned: vlad)

Details

Attachments

(1 file)

I wasn't thinking about this when we were going through bug 328232 -- the change at http://lxr.mozilla.org/seamonkey/source/gfx/thebes/src/gfxPlatformGtk.cpp#108 means that RENDER is *required* to be present, or we'll get a crash; on servers where RENDER is absent (Xvnc, notably), xrenderFormat is NULL.
Fix PlatformGtk pixmap creation; use the best visual we can get for ImageFormatRGB24 (the common case), fall back to image surfaces for the rest.

Also fixes bug with render surface creation -- we were creating a gdk pixmap, but not using it, since it was never passed into the gfxXlibSurface constructor!
Assignee: nobody → vladimir
Status: NEW → ASSIGNED
Attachment #215803 - Flags: review?
Attachment #215803 - Flags: review? → review?(roc)
Comment on attachment 215803 [details] [diff] [review]
fix gtk pixmap creation


>+        } else {
>+            GdkPixmap* pixmap = gdk_pixmap_new(nsnull, width, height,
>+                                                 xrenderFormat->depth);

Pretend that this doesn't re-delcare pixmap and shadow the previous declaration.
Attachment #215803 - Flags: review?(roc) → review+
Checked in, here's hoping for Tp drop!
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.