Closed
Bug 328824
Opened 18 years ago
Closed 18 years ago
Something duplicate in the MACRO "NS_IS_MOUSE_EVENT"
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: alfred.peng, Assigned: alfred.peng)
Details
Attachments
(1 file)
|
824 bytes,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
There MACRO "NS_IS_MOUSE_EVENT" has some duplicate definitions. We need to get rid of them.
|
Assignee | |
Comment 1•18 years ago
|
||
Patch for trunk. Get rid of the duplicates and add NS_MOUSE_ACTIVATE to the MACRO.
Assignee: general → alfred.peng
Status: NEW → ASSIGNED
Attachment #213441 -
Flags: superreview?(neil)
Attachment #213441 -
Flags: review?(timeless)
|
||
Comment 2•18 years ago
|
||
NS_IS_MOUSE_EVENT isn't very heavily used, maybe roc would prefer it inline?
Comment on attachment 213441 [details] [diff] [review] Patchv1 I don't really care if it's inline or not. Probably it should actually be a real, non-inline function. Adding NS_MOUSE_ACTIVATE is a significant change but I guess it makes sense.
Attachment #213441 -
Flags: superreview?(neil)
Attachment #213441 -
Flags: superreview+
Attachment #213441 -
Flags: review?(timeless)
Attachment #213441 -
Flags: review+
Checking in nsGUIEvent.h; /cvsroot/mozilla/widget/public/nsGUIEvent.h,v <-- nsGUIEvent.h new revision: 3.128; previous revision: 3.127 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•