Closed Bug 328832 Opened 18 years ago Closed 18 years ago

Add filter to view saved passwords dialog

Categories

(Toolkit :: Password Manager, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 327048

People

(Reporter: allan, Assigned: allan)

Details

Attachments

(1 file)

It is not easy to find the saved password for a domain, if you have many saved passwords. It could be stored under www.example.com, example.com, http://www.example.com, https://www.example.com, etc. etc.

How about adding a filter like the one in "about:config"?
See also Suite bug 239653.
It should not be overly complicated, I'll look at it one of these days.
Assignee: nobody → allan
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
Here's a go. Bascially just copies the concept from viewconfig
Attachment #214428 - Flags: review?(neil)
Attachment #214428 - Flags: review?(neil) → review?(mconnor)
Comment on attachment 214428 [details] [diff] [review]
Patch

I found two problems with this patch; first is that if the list of signons changes then the filter is not applied; second is that filtered sorting is broken.
Comment on attachment 214428 [details] [diff] [review]
Patch

Oh, and I would have put the filter textbox and button between the remove and password buttons.
Wow, terribly bad testing from my part. I'll look at it.
Attachment #214428 - Flags: review?(mconnor)
(In reply to comment #4)
> (From update of attachment 214428 [details] [diff] [review] [edit])
> I found two problems with this patch; first is that if the list of signons
> changes then the filter is not applied;

Hmm, sort of intentional, but I should then at least have cleared the filter. But I guess that it makes more sense to keep the filter applied.

> second is that filtered sorting is broken.

As in, enter a filter and then click on one of the column header to change sorting? Works for me.

(In reply to comment #5)
> (From update of attachment 214428 [details] [diff] [review] [edit])
> Oh, and I would have put the filter textbox and button between the remove and
> password buttons.
 
Hmm, on my screen there is not an awful lot of room there. Are you sure?

A bigger problem though is that doing filtering and then removing stuff is borked. More work to do.
(In reply to comment #7)
> A bigger problem though is that doing filtering and then removing stuff is
> borked. More work to do.

Hmm, do we want a filter for "Passwords never saved" too? Normally I do not have many entries in that list... but to get the remove working with a filter, I either need to make the filter generic, make specific handling of it in Delete*FromTree(), or run through the deletedSignons and delete from allsignons.

I am much in favor of the first and let signons be the list of positions in allsignons that are shown (and do the same for rejects). Also saves the duplication of data... which I never really liked.

*** This bug has been marked as a duplicate of 327048 ***
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: