328876 - Avoid compiler warning in nsFrame::GetSelectionClosestFrame()

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Uri Bernstein]

The assignement in the while loop in nsFrame::GetSelectionClosestFrame() generates the warning:

mozilla/layout/generic/nsFrame.cpp:2566: warning: suggest parentheses around assignment used as truth value

I missed this when reviewing bug 316281.

Comment 1

[Uri Bernstein]

Attachment: patch

Comment 2

[Eli Friedman]

Seems a bit silly to add an extra set of parentheses, but fine; if you want to separate out the assignment from the test, that would be fine too.  It doesn't particularly matter to me.

I don't think I'm allowed to grant r+ on this,but I would if I could; roc?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 213488 [details] [diff] [review]
patch

The style here is pretty bad. Use a for loop instead

for (; kid; kid = kid->GetNextSibling())

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

r+ permission is rather fluid ... anything's fine until someone notices and objects :-). Basically if someone is the master of some area then no-one's going to object. So no-one would object if Uri r+'ed a bidi bug, or if Bernd r+'ed a table patch. Eli, you seem to be a jack of all trades, so I'm not sure what you're master of :-). I certainly wouldn't have minded if you had r+'ed. If you ask for sr from someone else, then they get a chance to decide on the appropriateness of the reviewer anyway.

Comment 5

[Uri Bernstein]

Attachment: patch v2

Per roc's suggestion.

Comment 6

[Uri Bernstein]

Checked in:
Checking in layout/generic/nsFrame.cpp;
/cvsroot/mozilla/layout/generic/nsFrame.cpp,v  <--  nsFrame.cpp
new revision: 3.623; previous revision: 3.622
done